Skip to content

http-client-java, support advanced-versioning on @added optional parameter in TypeSpec, in non-DPG - #9087

Merged
Weidong Xu (weidongxu-microsoft) merged 56 commits into
microsoft:mainfrom
weidongxu-microsoft:http-client-java_versioning-non-dpg
Dec 1, 2025
Merged

http-client-java, support advanced-versioning on @added optional parameter in TypeSpec, in non-DPG#9087
Weidong Xu (weidongxu-microsoft) merged 56 commits into
microsoft:mainfrom
weidongxu-microsoft:http-client-java_versioning-non-dpg

Conversation

@weidongxu-microsoft

@weidongxu-microsoftWeidong Xu (weidongxu-microsoft) commented Nov 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

fixAzure/autorest.java#3225

This is already supported in DPG.
Here we support this for management. It should also apply to azure-v2, but we do not have test on it (as azure-v2 lib is not released).

This is enabled by advanced-versioning emitter option.

Test case

typespec/packages/http-client-java/generator/http-client-generator-test/tsp/arm-versioned.tsp

Lines 40 to 42 in 00fcc47

@added(Versions.v2024_10_01_preview)
@query
newParameter?:string;

The difference on output be demonstrated here
2fe0045

@weidongxu-microsoft
fallback to version compare by date
7c81a00
@weidongxu-microsoft
set to undefined, if cannot find version in apiVersions
941939b
@weidongxu-microsoft
nit
c598d4e
@weidongxu-microsoft
fix lint
e49c321
@weidongxu-microsoft
test case
225dd59
@weidongxu-microsoft
nit to cover the case of the erasure of preview api-version
a668d88
@weidongxu-microsoft
Merge branch 'main' into http-client-java_versioning-non-dpg
ea588f3
@weidongxu-microsoft
partial tool
8d2f7ab
@weidongxu-microsoft
simple method uses WithResponse
ff2e84e
@weidongxu-microsoft
enhance
bb96c02
@weidongxu-microsoft
Merge branch 'main' into http-client-java_versioning-non-dpg
032f3a9
@weidongxu-microsoft
improve client method template to recognize parameter that need to be…
99ae880
… locally initialized
@weidongxu-microsoft
format
f01061b
@weidongxu-microsoft
regen
d6652f0
@weidongxu-microsoft
advanced versioning for arm-versioned test
0aa271a
@weidongxu-microsoft
regen with advanced-versioning
5e17044
@weidongxu-microsoft
test
a61c34a
@weidongxu-microsoft
Merge branch 'main' into http-client-java_versioning-non-dpg
ce526d0
@weidongxu-microsoft
update addOptionalVariables
0fa3f33
@weidongxu-microsoft
Revert "update addOptionalVariables"
b4fa958
This reverts commit 0fa3f33.
@weidongxu-microsoft
overload for LRO createOrUpdate in mgmt
d8f7ed4
@weidongxu-microsoft
overload for method for lro and pageable
ffb4c88
@weidongxu-microsoft
regen
a451335
@weidongxu-microsoft
mgmt, update logic for taking the client method of full parameters
64218ae
@weidongxu-microsoft
update npm deps
d99c9cd
@weidongxu-microsoft
bug fix
2b3b222
@weidongxu-microsoft
regen
9653e35
@weidongxu-microsoft
update test
7648f09
@weidongxu-microsoft
make a diff
4991205
@weidongxu-microsoft
Revert "make a diff"
2fe0045
This reverts commit 4991205.
@weidongxu-microsoft

Weidong Xu (weidongxu-microsoft) commented Nov 26, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Updated test case (now include Get and Delete)

Difference on output demonstrated

@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) marked this pull request as ready for review November 26, 2025 10:14
Closed
@weidongxu-microsoftWeidong Xu (weidongxu-microsoft) changed the title http-client-java, support advanced-versioning in non-DPGhttp-client-java, support advanced-versioning on @added optional parameter in TypeSpec, in non-DPGNov 27, 2025
@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) marked this pull request as ready for review November 28, 2025 01:52
haolingdong-msft
Haoling Dong (haolingdong-msft) reviewed Nov 28, 2025
View reviewed changes
Comment threadpackages/http-client-java/generator/http-client-generator-test/Generate.ps1
Comment thread...va/com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClientMethodType.java
Comment thread...in/java/com/microsoft/typespec/http/client/generator/core/template/ClientMethodTemplate.java
Comment thread...c/main/java/com/microsoft/typespec/http/client/generator/core/mapper/ClientMethodMapper.java
Comment thread...ent-generator-test/src/main/java/tsptest/armversioned/fluent/TopLevelArmResourcesClient.java
Merged via the queue into microsoft:main with commit f16d773Dec 1, 2025
26 checks passed
@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) deleted the http-client-java_versioning-non-dpg branch December 1, 2025 09:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@haolingdong-msftHaoling Dong (haolingdong-msft)haolingdong-msft approved these changes
@srnagarSrikanta (srnagar)Awaiting requested review from srnagar
@anuchandyAnu Thomas (anuchandy)Awaiting requested review from anuchandy
@XiaofeiCaoXiaofei Cao (XiaofeiCao)Awaiting requested review from XiaofeiCaoXiaofeiCao is a code owner

Assignees

No one assigned

Labels

emitter:client:javaIssue for the Java client emitter: @typespec/http-client-java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mgmt, support advanced-versioning on @added optional parameter in TypeSpec

5 participants

@weidongxu-microsoft@azure-sdk@haolingdong-msft@XiaofeiCao