Skip to content

[botan] Fix error C2039: 'string': is not a member of 'std' - #40192

Merged
Billy O'Neal (BillyONeal) merged 2 commits into
microsoft:masterfrom
JonLiu1993:dev/Jon/botan
Jul 31, 2024
Merged

[botan] Fix error C2039: 'string': is not a member of 'std'#40192
Billy O'Neal (BillyONeal) merged 2 commits into
microsoft:masterfrom
JonLiu1993:dev/Jon/botan

Conversation

@JonLiu1993

@JonLiu1993 JonLiu1993 commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

In an internal version of Visual Studio, botan install failed with following error:

build\include\internal\botan/internal/pcurves_id.h(57): error C2039: 'string': is not a member of 'std'

This issue caused by the STL PR: microsoft/STL#4633, and according to Stephan's suggestion, the affected files need to include the Standard <string> header.

I have submitted an issue on the qt upstream: randombit/botan#4278

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 31, 2024
@BillyONeal
Billy O'Neal (BillyONeal) merged commit d114d59 into microsoft:master Jul 31, 2024
@BillyONeal

Copy link
Copy Markdown
Member

Thanks for the fix and for following up with upstream!

@JonLiu1993
JonLiu1993 deleted the dev/Jon/botan branch August 1, 2024 01:50
@Cheney-W Cheney Wang (Cheney-W) added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants