Uh oh!
There was an error while loading. Please reload this page.
Add attributes for NativeAOT safety - #1196
Merged
Merged
Conversation
But the native AOT test project produces dozens more. :(
Eric Erhardt (eerhardt) added a commit
to eerhardt/aspire
that referenced
this pull request
Jun 11, 2025
Since ProxyGeneration always generates IL code using RefEmit, it will never work in native AOT'd apps. But currently it is still brought into the app because RpcMarshalableConverterFactory (used by SystemTextJsonFormatter by default) eventually calls into it. To remove references to Newtonsoft.Json, we can cut this off in AOT'd apps by checking if dynamic code isn't supported and throw an exception. This will allow ProxyGeneration to be trimmed from the final app. This isn't a perfect fix, but instead a compromise. The best fix would be to make RpcMarshalableConverterFactory work correctly in AOT'd apps.
Cut ProxyGeneration out if dynamic code isn't supported
David Fowler (davidfowl) pushed a commit
to microsoft/aspire
that referenced
this pull request
Jun 17, 2025
* Start the beginning of AOT'ing the Aspire.Cli. Depends on microsoft/vs-streamjsonrpc#1196 * Revert cli.csproj changes * Revert Designer.cs changes * Share state object types across CLI and Hosting. * Split the Backchannel data types across assemblies again * Revert launchSettings.json
…bility. There are a couple patterns here: - Use GetMemberWithSameMetadataDefinitionAs to reflect on generic types/methods in a statically verifiable fashion. This method only exists in .NET 6+. - Suppress warnings when using GetInterfaces when the Type is annotated as preserve 'All'. dotnet/linker#1731 - When looking for a hard-coded interface like IProgress<T>, any preserved Type that implements the interface won't have the interface trimmed. - MethodNameMap uses GetInterfaceMap, which may not work in all cases. See dotnet/runtime#89157
…te on the Type parameter.
- Use for loop to avoid Roslyn analyzer warning. - Condition the suppression on !NET10.
…bility. (#1207) * Refactor code and annotations to fix all warnings in NativeAOTCompatibility. There are a couple patterns here: - Use GetMemberWithSameMetadataDefinitionAs to reflect on generic types/methods in a statically verifiable fashion. This method only exists in .NET 6+. - Suppress warnings when using GetInterfaces when the Type is annotated as preserve 'All'. dotnet/linker#1731 - When looking for a hard-coded interface like IProgress<T>, any preserved Type that implements the interface won't have the interface trimmed. - MethodNameMap uses GetInterfaceMap, which may not work in all cases. See dotnet/runtime#89157 * Refactor TrackerHelper to not need DynamicallyAccessedMembers attribute on the Type parameter. * Respond to PR feedback - Use for loop to avoid Roslyn analyzer warning. - Condition the suppression on !NET10.
Andrew Arnott (AArnott)
marked this pull request as ready for review
June 19, 2025 00:29
Andrew Arnott (AArnott)
requested review from
Eric Erhardt (eerhardt) and Matteo Prosperi (matteo-prosperi)June 19, 2025 00:30
Andrew Arnott (AArnott)force-pushed
the
NativeAOT
branch
from
June 19, 2025 01:24
3c63377 to
252189fCompare- Remove leftover comment - Fix some incorrect trimming annotations
Eric Erhardt (eerhardt)
approved these changes
Jun 19, 2025
Eric Erhardt (eerhardt)
left a comment
Member
There was a problem hiding this comment.
These changes LGTM.
I found a few minor pieces of feedback which I addressed in #1210.
Matteo Prosperi (matteo-prosperi)
approved these changes
Jun 19, 2025
Andrew Arnott (AArnott)
enabled auto-merge
June 19, 2025 16:41
Eric Erhardt (eerhardt)
approved these changes
Jun 19, 2025
Matteo Prosperi (matteo-prosperi)
approved these changes
Jun 19, 2025
This was referenced Jan 22, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't get StreamJsonRpc to be NativeAOT safe in any significant way, but now attributes guard the areas that are not safe, and gives us a backlog of things to improve on.