Uh oh!
There was an error while loading. Please reload this page.
Remove Dependency on Newtonsoft.Json From Protocol objects - #1198
Merged
Andrew Arnott (AArnott) merged 3 commits intoJun 17, 2025
Merged
Conversation
When trimming or native AOT'ing an app, we want to remove Newtonsoft.Json dependencies when possible because it brings in a lot of AOT warnings and adds a lot of size to the final app. Begin by removing these simple cases in the ToStrings of JsonRpcError, Request, and Result. ToString methods of instantiated types can never be trimmed, so the code in them is always preserved.
Andrew Arnott (AArnott)
requested changes
Jun 13, 2025
Andrew Arnott (AArnott)
left a comment
Member
There was a problem hiding this comment.
Looks very good.
Uh oh!
There was an error while loading. Please reload this page.
Andrew Arnott (AArnott)
approved these changes
Jun 17, 2025
Andrew Arnott (AArnott)
commented
Jun 17, 2025
Member
/azp run |
Andrew Arnott (AArnott)
enabled auto-merge
June 17, 2025 15:51
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 22, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trimming or native AOT'ing an app, we want to remove Newtonsoft.Json dependencies when possible because it brings in a lot of AOT warnings and adds a lot of size to the final app.
Begin by removing these simple cases in the ToStrings of JsonRpcError, Request, and Result. ToString methods of instantiated types can never be trimmed, so the code in them is always preserved.
cc Andrew Arnott (@AArnott)