Skip to content

Reduce trimming demands for RPC target objects - #1233

Merged
Andrew Arnott (AArnott) merged 1 commit into
mainfrom
dev/andarno/reduceTrimDemands
Jul 24, 2025
Merged

Reduce trimming demands for RPC target objects#1233
Andrew Arnott (AArnott) merged 1 commit into
mainfrom
dev/andarno/reduceTrimDemands

Conversation

@AArnott

@AArnottAndrew Arnott (AArnott) commented Jul 23, 2025

Copy link
Copy Markdown
Member

I don't think this nets to any actual win, because the overall target object still has an All demand placed on it, but I'm working to weed this down and ultimately offer an alternative API for building this up, so this is just a step.

CopilotAI reviewed Jul 23, 2025

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

eerhardt
Eric Erhardt (eerhardt) reviewed Jul 24, 2025
View reviewed changes
Comment threadsrc/StreamJsonRpc/Reflection/RpcTargetInfo.cs Outdated
Comment threadsrc/StreamJsonRpc/Reflection/RpcTargetInfo.cs Outdated
@AArnott
Andrew Arnott (AArnott)force-pushed the dev/andarno/reduceTrimDemands branch from cb808c7 to c88feb8CompareJuly 24, 2025 16:37
@AArnott
Andrew Arnott (AArnott) merged commit bb0a0d1 into mainJul 24, 2025
6 checks passed
@AArnott
Andrew Arnott (AArnott) deleted the dev/andarno/reduceTrimDemands branch July 24, 2025 22:23
This was referenced Jan 22, 2026
Merged
Merged
Closed
Merged
@dependabotdependabotBot mentioned this pull request Feb 9, 2026
Merged
@dependabotdependabotBot mentioned this pull request Feb 23, 2026
Closed
@dependabotdependabotBot mentioned this pull request May 18, 2026
Closed
This was referenced Jun 8, 2026
Closed
Merged
This was referenced Jun 15, 2026
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@RyanToth3Ryan Toth (RyanToth3)RyanToth3 approved these changes
+1 more reviewer
@eerhardtEric Erhardt (eerhardt)eerhardt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AArnott@eerhardt@RyanToth3