Uh oh!
There was an error while loading. Please reload this page.
Only suppress diagnostics when the interceptor is running - #1235
Merged
Conversation
Andrew Arnott (AArnott)
requested review from
Ryan Toth (RyanToth3), Copilot and Eric Erhardt (eerhardt)July 24, 2025 14:57
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where a diagnostic suppressor was running unconditionally while its corresponding interceptor required opt-in configuration, causing inappropriate suppression of trim/dynamic code warnings.
- Extracts interceptor enablement logic into a shared utility method
- Adds conditional check to only suppress diagnostics when interceptors are enabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ProxyGenerator.cs | Extracts interceptor enablement logic into a reusable static method |
| AttachAOTDiagnosticSuppressor.cs | Adds early return when interceptors are disabled to prevent inappropriate diagnostic suppression |
Ryan Toth (RyanToth3)
approved these changes
Jul 24, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 22, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1223 I added a source generator with an interceptor capability and a diagnostic suppressor. But the diagnostic suppressor ran unconditionally while the interceptor required opt-in, which would hide trim/dynamic code warnings inappropriately.
This fixes that.