Uh oh!
There was an error while loading. Please reload this page.
Use PolyType shapes for events - #1297
Merged
Andrew Arnott (AArnott) merged 5 commits intoOct 2, 2025
Merged
Conversation
This avoids the need for `RpcTargetMetadata.RegisterEventArgs<T>()` so long as you construct an `RpcTargetMetadata` based on PolyType shapes. Closes#1280 (because some commit in this branch needs to)
Andrew Arnott (AArnott)
requested review from
Ryan Toth (RyanToth3) and murphymcquet-msftSeptember 23, 2025 02:37
Andrew Arnott (AArnott)
enabled auto-merge
September 23, 2025 02:38
Ryan Toth (RyanToth3)
approved these changes
Sep 23, 2025
This means more APIs have `[RequiresDynamicCode]` on them, but these APIs have better alternatives based on PolyType shapes. The problem with the old design was that an entire process (or AppDomain) would succeed based on any one party calling `RegisterEventArgs<T>()` or `EnableDynamicEventHandlerCreation()`, causing libraries to potentially rely on another party to call those APIs without realizing it, and then malfunctioning when the other code was removed. With the new design, code will more reliably either succeed or fail on its own merits. Closes#1275
Andrew Arnott (AArnott)
marked this pull request as draft
September 23, 2025 12:51
auto-merge was automatically disabled
September 23, 2025 12:51
Pull request was converted to draft
Andrew Arnott (AArnott)force-pushed
the
dev/andarno/eventShapes
branch
from
September 23, 2025 12:52
4d160ee to
6d468a0CompareAndrew Arnott (AArnott)
marked this pull request as ready for review
October 2, 2025 17:37
Andrew Arnott (AArnott)
enabled auto-merge
October 2, 2025 17:55
Ryan Toth (RyanToth3)
approved these changes
Oct 2, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 22, 2026
This was referenced Jun 8, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use PolyType shapes for events
This avoids the need for
RpcTargetMetadata.RegisterEventArgs<T>()so long as you construct anRpcTargetMetadatabased on PolyType shapes.Closes#1280
Drop mutable, idempotent statics from RpcTargetMetadata
This means more APIs have
[RequiresDynamicCode]on them, but these APIs have better alternatives based on PolyType shapes.The problem with the old design was that an entire process (or AppDomain) would succeed based on any one party calling
RegisterEventArgs<T>()orEnableDynamicEventHandlerCreation(), causing libraries to potentially rely on another party to call those APIs without realizing it, and then malfunctioning when the other code was removed.With the new design, code will more reliably either succeed or fail on its own merits.
Closes#1275