Skip to content

clang-format/tidy version comparisons fail for some builds - #12813

Merged
Bob Brown (bobbrow) merged 1 commit into
mainfrom
bobbrow/clangVersion
Oct 7, 2024
Merged

clang-format/tidy version comparisons fail for some builds#12813
Bob Brown (bobbrow) merged 1 commit into
mainfrom
bobbrow/clangVersion

Conversation

@bobbrow

@bobbrowBob Brown (bobbrow) commented Oct 7, 2024

Copy link
Copy Markdown
Member

Fixes: #12806

Use regular expressions to find the version number instead of token position.

@bobbrow
Bob Brown (bobbrow) requested a review from a teamOctober 7, 2024 17:53
sean-mcmanus
Sean McManus (sean-mcmanus) approved these changes Oct 7, 2024
View reviewed changes

@sean-mcmanusSean McManus (sean-mcmanus) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems theoretically possible for a custom clang build to omit a patch version, but I don't think that's normal so maybe it's okay to not support that.

@sean-mcmanus

Sean McManus (sean-mcmanus) commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Is this for 1.22.8 or 1.23.0?

@bobbrow

Bob Brown (bobbrow) commented Oct 7, 2024

Copy link
Copy Markdown
MemberAuthor

It seems theoretically possible for a custom clang build to omit a patch version, but I don't think that's normal so maybe it's okay to not support that.

I suppose we can wait to see if that's a capability people ask for.

@bobbrow

Bob Brown (bobbrow) commented Oct 7, 2024

Copy link
Copy Markdown
MemberAuthor

Is this for 1.22.8 or 1.23.0?

I don't have a strong opinion. If it's not in 1.22, we may be doing a 1.23.0 pre-release shortly after.

@sean-mcmanus

Sean McManus (sean-mcmanus) commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

I don't have a strong opinion. If it's not in 1.22, we may be doing a 1.23.0 pre-release shortly after.

It sounds like 1.22.8 will be a pre-release still so it seems safe enough to go into that.

@bobbrow

Bob Brown (bobbrow) commented Oct 7, 2024

Copy link
Copy Markdown
MemberAuthor

ok. I'll merge this in now.

@bobbrow
Bob Brown (bobbrow) merged commit c2baddd into mainOct 7, 2024
@bobbrow
Bob Brown (bobbrow) deleted the bobbrow/clangVersion branch October 7, 2024 20:54
@bshoshanyBarak Shoshany (bshoshany) mentioned this pull request Oct 9, 2024
Open
@bobbrowBob Brown (bobbrow) modified the milestones: 1.22.0, 1.22Jan 31, 2025
@bobbrowBob Brown (bobbrow) mentioned this pull request Jan 31, 2025
Closed
@sean-mcmanusSean McManus (sean-mcmanus) mentioned this pull request Jun 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-mcmanusSean McManus (sean-mcmanus)sean-mcmanus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

cpptools
Status: Done

Milestone

1.22

Development

Successfully merging this pull request may close these issues.

clang-format/tidy version comparisons fail for some builds

2 participants

@bobbrow@sean-mcmanus