Skip to content

Show hover cards when issue numbers are followed by ) #1813

Description

@ScottTodd

We'd like to have code comments like // TODO(#123456), but a trailing space (or other whitelisted character) is needed for the hover cards to appear, like // TODO(#123456 ).

Looks like \) could be added to the final capture group here:

export const ISSUE_EXPRESSION = /(([^\s]+)\/([^\s]+))?#([1-9][0-9]*)($|[\s\:\;\-\(\=])/;

Not sure if there are other usage patterns that would be false positives with that character allowed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions