Skip to content

no config debug: Fix error when multiple vscode windows are open - #918

Merged
Rich Chiodo (rchiodo) merged 10 commits into
microsoft:mainfrom
Zentrik:fix_multi_window_dbg
Feb 23, 2026
Merged

no config debug: Fix error when multiple vscode windows are open#918
Rich Chiodo (rchiodo) merged 10 commits into
microsoft:mainfrom
Zentrik:fix_multi_window_dbg

Conversation

@Zentrik

@ZentrikZentrik commented Jan 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Should fix#916, but getting this installed locally seemed sufficiently complicated that I gave up. I figured out the nox stuff, I tested with two windows and this worked.
Fix is:

  1. Only watch a specific endpoint file
  2. Make sure this endpoint file is unique (I imagine the workspace file path can be non unique across vscode windows)

@Zentrik
no config debug: Fix error when multiple vscode windows are open
c790e07
Should fixmicrosoft#916, but getting this installed locally seemed sufficiently complicated that I gave up.
Fix is:
1. Only watch a specific endpoint file
2. Make sure this endpoint file is unique (I imagine the workspace file path can be non unique across vscode windows)
@Zentrik
[AI] Update tests
7e942c6
@Zentrik
Fix typo
eec9bbe
@Zentrik
Remove driveby fix
b4a023b
@ZentrikZentrik mentioned this pull request Jan 8, 2026
Open
@rchiodoRich Chiodo (rchiodo) added the bug Issue identified by VS Code Team member as probable bug label Jan 8, 2026
@rchiodo

Rich Chiodo (rchiodo) commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Whoops, didn't meant to close this. Zentrik it looks like this is causing a bunch of test failures.

@Zentrik
Cleanup test and try to fix it failing on windows
c997d69
I guess this is what I get for trusting AI at midnight.
@Zentrik
Fix failing test on windows take 2
bedc7d2
The error seems to be that `base` is `c:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.noConfigDebugAdapterEndpoints` but `noConfigEndpointDir` is `C:\Users\RUNNER~1\AppData\Local\Temp\.noConfigDebugAdapterEndpoints` (the C is capitalised). Getting the fsPath of the URI should normalise the path the same as `base`.
@Zentrik

Zentrik commented Jan 9, 2026

Copy link
Copy Markdown
ContributorAuthor

Zentrik it looks like this is causing a bunch of test failures.

Sorry about that, thanks for reviewing. I think it should be fixed now, o/w will have to wait till tmrw and I'll boot into windows to debug further.

@Zentrik

Zentrik commented Jan 10, 2026

Copy link
Copy Markdown
ContributorAuthor

Including the workspace part of the hash seems unnecessary given the inclusion of the sessionId so I removed it, with the added benefit that we now don't have to throw an error if no workspace folder is found. Including the sessionId in the hash does mean that the VSCODE_DEBUGPY_ADAPTER_ENDPOINTS env var changes if you reload the window/extension, but I couldn't see a way around that other than accepting that VSCODE_DEBUGPY_ADAPTER_ENDPOINTS might not be unique.

@Zentrik

Zentrik commented Feb 21, 2026

Copy link
Copy Markdown
ContributorAuthor

Rich Chiodo (@rchiodo) do you mind taking another look at this, the test failures should be fixed. Thanks.

@rchiodo

Rich Chiodo (rchiodo) commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Feb 23, 2026

Copy link
Copy Markdown
Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

rchiodo
Rich Chiodo (rchiodo) reviewed Feb 23, 2026
View reviewed changes
Comment threadsrc/extension/noConfigDebugInit.ts
@rchiodo
Rich Chiodo (rchiodo) merged commit 247c9bf into microsoft:mainFeb 23, 2026
18 checks passed
@Zentrik

Zentrik commented Feb 26, 2026

Copy link
Copy Markdown
ContributorAuthor

🎉 thank you both for reviewing

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodoRich Chiodo (rchiodo)rchiodo approved these changes
@StellaHuang95Stella Huang (StellaHuang95)StellaHuang95 approved these changes

Assignees

No one assigned

Labels

bugIssue identified by VS Code Team member as probable bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No Config Debugging errors when multiple vscode windows are open

3 participants

@Zentrik@rchiodo@StellaHuang95