Skip to content

Add dynamic FastAPI debug config - #19505

Merged
Paula (paulacamargo25) merged 2 commits into
microsoft:mainfrom
paulacamargo25:19452-Add-FastApi-debug-config
Jul 21, 2022
Merged

Add dynamic FastAPI debug config#19505
Paula (paulacamargo25) merged 2 commits into
microsoft:mainfrom
paulacamargo25:19452-Add-FastApi-debug-config

Conversation

@paulacamargo25

@paulacamargo25Paula (paulacamargo25) commented Jul 20, 2022

Copy link
Copy Markdown

closed: #19452

@paulacamargo25Paula (paulacamargo25) added area-debugging feature-request Request for new features or functionality skip tests Updates to tests unnecessary labels Jul 20, 2022
@paulacamargo25Paula (paulacamargo25) added this to the July 2022 milestone Jul 20, 2022
karrtikr
Kartik Raj (karrtikr) suggested changes Jul 20, 2022
View reviewed changes
Comment threadsrc/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts Outdated
Comment threadsrc/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts Outdated
Comment threadsrc/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts Outdated
Comment threadsrc/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts Outdated
karrtikr
Kartik Raj (karrtikr) approved these changes Jul 21, 2022
View reviewed changes

@karrtikrKartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of Django as well, LGTM.

@paulacamargo25
Paula (paulacamargo25) merged commit 7c3498c into microsoft:mainJul 21, 2022
Kludex
Marcelo Trylesinski (Kludex) reviewed Aug 4, 2022
View reviewed changes
Comment threadsrc/client/debugger/extension/configuration/dynamicdebugConfigurationService.ts
private async getFastApiPath(folder: WorkspaceFolder) {
const possiblePaths = await this.getPossiblePaths(folder, ['main.py', 'app.py', '*/main.py', '*/app.py']);
const regExpression = /app\s*=\s*FastAPI\(/;
const flaskPaths = await asyncFilter(possiblePaths, async (possiblePath) =>

@KludexMarcelo Trylesinski (Kludex)Aug 4, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fastapi paths

Wes McKinney (wesm) pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@paulacamargo25@wesm
Add dynamic FastAPI debug config (microsoft/vscode-python#19505)
292a677
* Add dynamic FastAPI debug config
* Improve performance
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@KludexMarcelo Trylesinski (Kludex)Kludex left review comments
@karrtikrKartik Raj (karrtikr)karrtikr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@paulacamargo25Paula (paulacamargo25)

Labels

area-debuggingfeature-requestRequest for new features or functionalityskip testsUpdates to tests unnecessary

Projects

None yet

Milestone

July 2022

Development

Successfully merging this pull request may close these issues.

Implement automatic configuration for FastAPI

3 participants

@paulacamargo25@Kludex@karrtikr