Skip to content

Tips notifications for rarely used functionality - #1610

Merged
RedMickey merged 22 commits into
masterfrom
tips-notifications-for-rarely-used-functionality
Aug 2, 2021
Merged

Tips notifications for rarely used functionality#1610
RedMickey merged 22 commits into
masterfrom
tips-notifications-for-rarely-used-functionality

Conversation

@etatanova

@etatanovaetatanova commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

Related issue:#1278

Changes:

  • Implemented tips notifications logic
  • Added tips storage
  • Moved the logic of downloading a config to a separate module

@etatanova
etatanova requested a review from RedMickeyJuly 15, 2021 11:40
RedMickey
RedMickey reviewed Jul 21, 2021
View reviewed changes
Comment threadREADME.md Outdated
RedMickey
RedMickey reviewed Jul 21, 2021
View reviewed changes
Comment threadREADME.md Outdated
RedMickey
RedMickey reviewed Jul 23, 2021
View reviewed changes
Comment threadsrc/extension/tipsNotificationsService/tipsNotificationService.ts Outdated
RedMickey
RedMickey reviewed Jul 23, 2021
View reviewed changes
Comment threadsrc/extension/tipsNotificationsService/tipsNotificationService.ts Outdated
JiglioNero
JiglioNero reviewed Jul 23, 2021
View reviewed changes
Comment threadsrc/extension/remoteConfigHelper.ts Outdated
Comment threadsrc/extension/remoteConfigHelper.ts Outdated
Comment threadsrc/extension/tipsNotificationsService/tipsNotificationService.ts Outdated
@RedMickey
RedMickey merged commit f338085 into masterAug 2, 2021
@RedMickey
RedMickey deleted the tips-notifications-for-rarely-used-functionality branch August 2, 2021 17:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@RedMickeyRedMickeyRedMickey approved these changes
@JiglioNeroJiglioNeroJiglioNero approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@etatanova@RedMickey@JiglioNero