Skip to content

feat: add support for 64-bit registry access in key_access enum - #555

Merged
Duncan Horn (dunhor) merged 4 commits into
microsoft:masterfrom
ESiebigteroth:add-registry-64-bit-key-flags
Oct 30, 2025
Merged

feat: add support for 64-bit registry access in key_access enum#555
Duncan Horn (dunhor) merged 4 commits into
microsoft:masterfrom
ESiebigteroth:add-registry-64-bit-key-flags

Conversation

@ESiebigteroth

Copy link
Copy Markdown
Contributor

This PR extends the key_access enum in registry_helpers.h to support 64-bit registry access. The following new values have been added:

  • read64: Opens a key for reading from the 64-bit registry.
  • readwrite64: Opens a key for reading and writing from the 64-bit registry.

Additionally, the get_access_flags function has been updated to handle these new enum values appropriately.

@ESiebigteroth

Copy link
Copy Markdown
ContributorAuthor

#435 has a similar problem.

@ESiebigterothEricS (ESiebigteroth) changed the title Add support for 64-bit registry access in key_access enumfeat: add support for 64-bit registry access in key_access enumOct 29, 2025
@aursulis

Copy link
Copy Markdown
Contributor

As a drive-by since I was looking into whether WIL does this or not, could we add the KEY_WOW64_32KEY variants as well, assuming Microsoft would take this PR?

@dunhor

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment threadinclude/wil/registry_helpers.h Outdated
Comment threadinclude/wil/registry_helpers.h
@ESiebigteroth

Copy link
Copy Markdown
ContributorAuthor

Thanks Duncan Horn (@dunhor) and Chris Guzak (@ChrisGuzak) for reviewing and approving the changes! I really appreciate your time.
Let me know if there's anything else needed before merging.

@dunhor

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dunhor

Copy link
Copy Markdown
Member

@microsoft-github-policy-service rerun

1 similar comment
@dunhor

Copy link
Copy Markdown
Member

@microsoft-github-policy-service rerun

@dunhor

Copy link
Copy Markdown
Member

Thanks Duncan Horn (@dunhor) and Chris Guzak (@ChrisGuzak) for reviewing and approving the changes! I really appreciate your time. Let me know if there's anything else needed before merging.

LGTM. I'm just not sure what's going on with the CLA bot. I wonder if it's somehow related to the outages yesterday. I'll try kicking it again later to see if it's resolved.

Comment threadinclude/wil/registry_helpers.h
@dunhor

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dunhor

Copy link
Copy Markdown
Member

Looks like I can't complete because I was the last to push... Chris Guzak (@ChrisGuzak), if you don't mind can you re-approve

@dunhor
Duncan Horn (dunhor) merged commit 50049c0 into microsoft:masterOct 30, 2025
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ESiebigteroth@aursulis@dunhor@ChrisGuzak@dmachaj