Uh oh!
There was an error while loading. Please reload this page.
feat: add support for 64-bit registry access in key_access enum - #555
Conversation
EricS (ESiebigteroth)
commented
Oct 29, 2025
#435 has a similar problem. |
Antanas Uršulis (aursulis)
commented
Oct 29, 2025
As a drive-by since I was looking into whether WIL does this or not, could we add the KEY_WOW64_32KEY variants as well, assuming Microsoft would take this PR? |
Duncan Horn (dunhor)
commented
Oct 29, 2025
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
EricS (ESiebigteroth)
commented
Oct 30, 2025
Thanks Duncan Horn (@dunhor) and Chris Guzak (@ChrisGuzak) for reviewing and approving the changes! I really appreciate your time. |
Duncan Horn (dunhor)
commented
Oct 30, 2025
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Duncan Horn (dunhor)
commented
Oct 30, 2025
@microsoft-github-policy-service rerun |
1 similar comment
Duncan Horn (dunhor)
commented
Oct 30, 2025
@microsoft-github-policy-service rerun |
Duncan Horn (dunhor)
commented
Oct 30, 2025
LGTM. I'm just not sure what's going on with the CLA bot. I wonder if it's somehow related to the outages yesterday. I'll try kicking it again later to see if it's resolved. |
Uh oh!
There was an error while loading. Please reload this page.
Duncan Horn (dunhor)
commented
Oct 30, 2025
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Duncan Horn (dunhor)
commented
Oct 30, 2025
Looks like I can't complete because I was the last to push... Chris Guzak (@ChrisGuzak), if you don't mind can you re-approve |
Uh oh!
There was an error while loading. Please reload this page.
This PR extends the key_access enum in registry_helpers.h to support 64-bit registry access. The following new values have been added:
Additionally, the get_access_flags function has been updated to handle these new enum values appropriately.