Uh oh!
There was an error while loading. Please reload this page.
Using robots to fix/update docs part 6: cppwinrt* headers - #657
Using robots to fix/update docs part 6: cppwinrt* headers#657Duncan Horn (dunhor) wants to merge 4 commits into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| * @def INIT_NOTIFYING_PROPERTY | ||
| * @brief use this to initialize a wil::single_threaded_notifying_property in your class constructor. | ||
| */ | ||
| #define INIT_NOTIFYING_PROPERTY(NAME, VALUE) NAME(&m_propertyChanged, *this, L"" #NAME, VALUE) |
There was a problem hiding this comment.
This should be this->m_propertyChanged because the member comes from notify_property_changed_base, however that type uses CRTP and if the derived type is itself a template, then the base becomes dependent and this will fail under proper two phase name lookup.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
See #652 for more info on the effort.
Figured that I should probably group all the C++/WinRT headers into a single change. This is another one Copilot had a bit of trouble producing good/correct documentation to & required some TLC.
Additionally, while doing this I noticed a number of potential issues. I'll note them in comments as follow-ups; I want to leave these changes as doc updates only.