Uh oh!
There was an error while loading. Please reload this page.
Register restart for resume - #3858
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
| // The above was omitted initially as a security precaution to ensure that user input to '--log' wouldn't be passed directly to ShellExecute | ||
| ShellExecute(NULL, NULL, Runtime::GetPathTo(Runtime::PathName::DefaultLogLocation).wstring().c_str(), NULL, NULL, SW_SHOWNORMAL); | ||
| } | ||
| if (Settings::ExperimentalFeature::IsEnabled(Settings::ExperimentalFeature::Feature::Reboot) && |
There was a problem hiding this comment.
If the context is terminated (not with an exception, but "normally"), this code will still run. That may or may not be correct, but I want to make sure it is considered. It feels ok, but then I worry that it won't happen for an exception. I would say that we haven't been strict on the precise method for failures to propagate, which means that this code is likely to not run in some situations when it probably should.
Since this is experimental, it is fine to live here for now. But it will be good to keep this in mind.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Ryan (ryfu-msft)
commented
Dec 6, 2023
@microsoft-github-policy-service rerun |
Related to: #3165
Changes:
maxResumesthat limits the number of times a resume state can be "resumed". This is to ensure that continuous reboots don't occur.--waitargument is processed so that the user is prompted to continue before a reboot is kicked off.Microsoft Reviewers: Open in CodeFlow