Skip to content

PHP 8.5 support#37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milo merged 2 commits into from
Nov 24, 2025
Merged

PHP 8.5 support #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f712e20
PHP 8.5 is supported
dg Nov 24, 2025
429f23c
updated GitHub actions
dg Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [8.0, 8.1, 8.2, 8.3, 8.4]
php: [8.0, 8.1, 8.2, 8.3, 8.4, 8.5]

name: PHP ${{ matrix.php }} tests
steps:
Expand All@@ -21,7 +21,7 @@ jobs:
- run: composer install --no-progress --prefer-dist
- run: vendor/bin/tester tests -s
- if: failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: output
path: tests/**/output
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
}
],
"require": {
"php": ">=8.0 <8.5"
"php": "8.0 - 8.5"

CopilotAINov 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHP version constraint syntax "8.0 - 8.5" is not valid Composer syntax. This should be changed to a proper constraint like ">=8.0 <8.6" or "^8.0 || ^8.1 || ^8.2 || ^8.3 || ^8.4 || ^8.5". The hyphen syntax is not recognized by Composer for version ranges.

Suggested change
"php": "8.0 - 8.5"
"php": ">=8.0 <8.6"

Copilot uses AI. Check for mistakes.

@dgdgNov 25, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://getcomposer.org/doc/articles/versions.md#hyphenated-version-range-

},
"require-dev": {
"nette/tester": "^2.4"
Expand Down
3 changes: 3 additions & 0 deletions src/Github/Http/StreamClient.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,9 @@ protected function fileGetContents(string $url, array $contextOptions): array
$content = file_get_contents($url, false, $context);
restore_error_handler();

if (PHP_VERSION_ID >= 80400) {
$http_response_header = http_get_last_response_headers();
}
if (!isset($http_response_header)) {
throw new BadResponseException('Missing HTTP headers, request failed.', 0, $e);
}
Expand Down