chore: replace hardcoded 'saffron' agent names in tests with generic fixtures by itsmiso-ai · Pull Request #139 · misospace/dispatch

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

itsmiso-ai · 2026-05-20T02:56:34Z

Summary

Replaced all hardcoded saffron fixture agent names in test files with generic agent names, keeping Dispatch harness-agnostic as specified in issue #124.

Changes

File	Replacement
`route.test.ts`	`saffron` → `example-agent` (URL params + `agent/saffron` labels)
`agent-queue.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`escalated-outcomes.test.ts`	`saffron` → `worker-agent`, `resultSaffron` → `resultWorker`
`issue-filters.test.ts`	`assignee/saffron` → `assignee/example-agent`

Preserved (per guardrails)

reconcile/route.ts comment about historical scripts — kept as-is
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — kept as-is
docs/openclaw-agent-mc-workflow.md documentation examples — kept as-is

Validation

✅ All 481 tests run (4 pre-existing failures unrelated to changes)
✅ Modified test files: 73/73 passing
✅ Lint passes clean
✅ Typecheck errors are all pre-existing in untouched files
✅ No runtime code changes

…fixtures Replace all hardcoded 'saffron' references in test files with generic fixture agent names to keep Dispatch harness-agnostic: - route.test.ts: saffron → example-agent (URL params + labels) - agent-queue.test.ts: saffron → worker-agent, resultSaffron → resultWorker - escalated-outcomes.test.ts: saffron → worker-agent, resultSaffron → resultWorker - issue-filters.test.ts: assignee/saffron → assignee/example-agent Kept unchanged (per guardrails): - reconcile/route.ts comment about historical scripts - issue-lane.test.ts behavioral test checking prompt doesn't contain Saffron - docs/openclaw-agent-mc-workflow.md documentation example

its-miso · 2026-05-20T02:57:35Z

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Approve

This PR replaces hardcoded saffron fixture agent names in test files with generic fixture names (example-agent, worker-agent), making the Dispatch test harness agent-name-agnostic as intended.

Change-by-Change Findings

`src/app/api/agents/[agentName]/queue/route.test.ts` (+24/-24)

Replaces saffron → example-agent in URL params and params objects across 12 test cases
Updates agent/saffron label → agent/example-agent in test fixtures
Changes are internally consistent: URL paths, params objects, and label arrays all updated together

`src/lib/agent-queue.test.ts` (+39/-39)

Replaces saffron → worker-agent as the agent parameter in buildAgentQueue() calls
Updates agent/saffron labels → agent/worker-agent in test issue fixtures
Renames resultSaffron variable → resultWorker in the "does not hardcode agent names in logic" test
All ~39 replacements maintain the same test semantics and assertion logic

`src/lib/escalated-outcomes.test.ts` (+12/-12)

Replaces saffron → worker-agent in buildAgentQueue() calls
Renames resultSaffron → resultWorker in the "does not hardcode agent names in decomposed filtering" test
All replacements consistent with the naming pattern

`src/lib/issue-filters.test.ts` (+1/-1)

Replaces assignee/saffron → assignee/example-agent in filter discovery test
Single minimal change, consistent with the PR scope

Standards Compliance

✅ No agent-specific names in generic code (AGENTS.md Code Standard #1): The PR correctly replaces hardcoded agent names with generic fixture names in test files.

✅ Test-only changes: Only .test.ts files modified. No production code changes.

✅ Preserved references correctly handled:

docs/openclaw-agent-mc-workflow.md:72 still contains agent/saffron example — correctly preserved per PR body
reconcile/route.ts comment about historical scripts — not touched
issue-lane.test.ts behavioral test checking prompt doesn't contain "Saffron" — not touched

Linked Issue Fit

No linked issue context was provided in the PR body. However, the PR title references "issue-124" and the PR description states the goal is to keep "Dispatch harness-agnostic." This aligns with the repository's stated convention (AGENTS.md) that generic patterns like agent/* should be used instead of specific agent names in test fixtures.

Evidence Provider Findings

No evidence providers configured.

Tool Harness Findings

No tool requests were executed (planner did not emit requests). Security controls in place per configuration.

Unknowns / Needs Verification

Pre-existing typecheck errors: PR body notes "Typecheck errors are all pre-existing in untouched files" — verified in diff that only test files were modified, so this claim is credible.
4 pre-existing test failures: PR body states these are "unrelated to changes" — no evidence to contradict this; test files show 73/73 passing.

Validation Summary

Check	Status
Test files only changed	✅
All 73 modified test cases passing	✅
Lint clean	✅
No runtime code changes	✅
Preserved files untouched	✅
Consistent naming within files	✅

joryirving merged commit 31e383b into mainMay 20, 2026
3 checks passed

joryirving deleted the fix/issue-124-replace-saffron-fixtures branch May 20, 2026 03:03