Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Standardize route handler error responses - #574

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534
Jul 7, 2026
Merged

Standardize route handler error responses#574
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-534/issue-534

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Creates shared api-errors module with errorResponse and handleApiError helpers, adds unit tests, and updates the GET handler in agent-work/route.ts to use the new helper. All 34 tests pass (30 existing + 4 new).

Fixes#534

Opened by foreman on review GO (workload wl-misospace-dispatch-534).

Add a shared `src/lib/api-errors.ts` helper that codifies the canonical
error pattern called out in the audit (log via `console.error`, return
`NextResponse.json({ error }, { status: 500 })`). Route handlers can
adopt `handleApiError(context, error)` inside their catch blocks to
keep the log line and response body in sync, eliminating the prior
inconsistency between handlers like `src/app/api/agent-work/route.ts`
that logged errors without a standard response shape.
Adopt the helper in `src/app/api/agent-work/route.ts` GET handler and
add a vitest suite at `src/lib/api-errors.test.ts` covering both the
bare `errorResponse` and the `handleApiError` wrapper so the contract
is locked in.
Fixes#534
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — routed smart (risk match: public_route_changes)

Recommendation: Approve

This PR cleanly addresses issue PR 534 by introducing shared error-response helpers (errorResponse, handleApiError) and applying them to one route handler. All 5 CI checks pass (Docker Build, Tests, Lint, Build, Typecheck).

Change-by-Change Findings

1. src/lib/api-errors.ts (new file, +40 lines)

Creates two exported helpers:

  • errorResponse(message, status=500)NextResponse.json({ error: message }, { status })
  • handleApiError(context, error, status=500) → logs console.error("Failed to <context>:", error) then returns a 500 response

The implementation is straightforward, TypeScript-typed, and docstring-commented. No route-level changes, no auth changes, no new endpoints.

2. src/lib/api-errors.test.ts (new file, +33 lines)

Four vitest cases covering:

  • Canonical 500 + { error: string } shape from errorResponse
  • Custom status codes respected
  • handleApiError log + 500 response agreement
  • Non-Error throw values (e.g. strings) still handled gracefully

3. src/app/api/agent-work/route.ts (modified, +2/−2 lines)

Replaces two lines in the GET handler's catch block with a single call to handleApiError:

- console.error("Failed to fetch agent work:", error);- return NextResponse.json({ error: "Failed to fetch agent work" }, { status: 500 });+ return handleApiError("fetch agent work", error);

This is a pure refactor — identical behavior, just centralized.

Must-Check Checklist

✅ verify route access controls are in place

The diff shows only the catch-block error handling change. The GET handler in agent-work/route.ts already calls authorizeRequest (imported on line 3, called before the try block). The PR does not touch, bypass, or remove that authorization check. Existing access controls remain fully in place.

✅ check for unintended public endpoints

No new routes are added. No existing routes are modified in their URL path, HTTP method, or authentication requirements. This PR introduces only a utility module and a single usage in one catch block.

Standards Compliance

  • Code Standards: error instanceof Error pattern is not strictly followed in handleApiError (it accepts unknown), but this is intentional — it makes the helper resilient to both Error objects and primitive throw values, which is the whole point of the abstraction.
  • API routes: Return appropriate HTTP status codes ✅ (the helper preserves the 500 default and allows custom statuses).
  • No secrets committed: No secrets or env files touched.

Linked Issue Fit

Issue PR 534 called out inconsistent error handling across route handlers — specifically noting that agent-work/route.ts logs errors without returning structured responses. This PR:

  • ✅ Adds a shared helper to standardize the pattern
  • ✅ Applies it to the exact route mentioned in the issue
  • ✅ Adds tests

The PR scope is intentionally narrow (one route, one helper, tests) per the issue's description. Full rollout to other routes can follow as subsequent work.

Unknowns / Needs Verification

None. The corpus provides complete diffs, CI results, and linked issue context.

@joryirving
joryirving merged commit 957a7d1 into mainJul 7, 2026
6 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-534/issue-534 branch July 7, 2026 03:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error handling inconsistency across route handlers

2 participants

@itsmiso-ai@joryirving