feat: add Saffron Phase 1 runtime smoke checklist (#52)

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.

[itsmiso-ai]

Saffron Phase 1 — Runtime Smoke Checklist

Fixes#52

What this adds

An executable smoke-test script that validates all 11 pre-cutover acceptance criteria against a live Mission Control instance:

#	Check	Endpoint / Method
1	Health endpoint	GET /api/health → { ok: true, database: "ok" }
2	Automation sync	POST /api/automation/sync → success
3	Repo listing	GET /api/automation/repos → array
4	Issue sync	POST /api/sync → syncedCount > 0
5	Issue listing	GET /api/issues → array
6	Board page	GET /board → 200
7	Projects page	GET /projects → 200
8	Agent heartbeat	GET /api/agent-runs → heartbeat entries
9	Issue move + audit	POST /api/issues/move → audit log entry
10	No critical errors	Audit logs free of Prisma/BigInt/FK patterns
11	Failure isolation	Health endpoint resilient to MC failures

Usage

# Against local dev instance
node scripts/smoke-checklist.cjs http://localhost:3000
# Against staging/prod
node scripts/smoke-checklist.cjs https://mc.example.com
# CI-friendly (exits 1 on failure, prints JSON to stderr)
CI=1 node scripts/smoke-checklist.cjs https://mc-staging.example.com
# Via npm script
npm run smoke

Files

• scripts/smoke-checklist.cjs — executable Node.js smoke test (CommonJS, uses native fetch)
• docs/smoke-checklist.md — documentation with acceptance criteria table, manual verification steps, troubleshooting, and pre-cutover decision gate
• package.json — added "smoke" script

Design decisions

• CommonJS (.cjs): avoids ESM/CJS interop issues in a Node.js script; uses native fetch (no dependencies)
• Parallel execution: all checks run concurrently via Promise.all() for speed
• Skip logic: checks that require specific setup (e.g., heartbeat entries, no repos configured) gracefully skip instead of failing
• Cleanup: check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 adds and removes a status/test-smoke label to validate the move → audit log flow without leaving artifacts
• CI mode: CI=1 outputs machine-readable JSON to stderr and exits non-zero on any failure

[its-miso]

⚠️Automated recommendation: REQUEST CHANGES

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

Review Summary

Recommendation: Request Changes

This PR adds a well-structured runtime smoke checklist that covers all 11 acceptance criteria from issue #52. However, there is a critical inconsistency between the documentation and implementation that will cause confusion or failures for users following the docs.

---

Change-by-Change Findings

1. docs/smoke-checklist.md — INCONSISTENT USAGE

The documentation examples reference .mjs (ESM) in multiple places:

# Against local dev instance
node scripts/smoke-checklist.mjs http://localhost:3000# Against staging/prod
node scripts/smoke-checklist.mjs https://mc.example.com# CI-friendly
CI=1 node scripts/smoke-checklist.mjs https://mc-staging.example.com

But the actual script file is scripts/smoke-checklist.cjs (CommonJS) and package.json uses .cjs:

"smoke": "node scripts/smoke-checklist.cjs"

Any user who copies the documentation example will get an error because the file does not exist with .mjs extension.

Fix needed: Replace all smoke-checklist.mjs references with smoke-checklist.cjs.

2. scripts/smoke-checklist.cjs — Solid Implementation ✅

The script itself is well-crafted:

• Covers all 11 acceptance criteria
• Uses native fetch (no dependencies)
• Parallel execution via Promise.all()
• Proper skip logic for checks that require specific setup
• Check feat(deps)!: Update dependency tailwindcss (3.4.19 → 4.3.0) #9 includes cleanup of test label (status/test-smoke)
• CI mode outputs JSON to stderr and exits non-zero on failure
• Exit code 1 when checks fail, exit code 0 on success

3. AGENTS.md and README.md — Version Bump Documentation ⚠️

Both files document upgraded tech stack:

• Next.js 14 → 16.2.6
• Prisma ORM → Prisma v7 ORM
• node:20-bookworm-slim → node:24-bookworm-slim
• TypeScript v6, React v19, Tailwind CSS v4

These appear to be documentation updates for an ongoing dependency upgrade effort. The smoke checklist is tangentially related but includes these changes in this PR.

4. package.json — npm Script ✅

"smoke": "node scripts/smoke-checklist.cjs"

Correctly references the .cjs file.

---

Standards Compliance

Standard	Status	Notes
Label conventions	✅	Script uses status/test-smoke for cleanup test
AuditLog requirement	✅	Check #9 verifies audit log entry creation
Best-effort patterns	✅	Skips handled gracefully instead of failing
No agent-specific names	✅	Script checks for generic saffron in agentName, but this is contextual to the issue

---

Linked Issue Fit

Issue #52 acceptance criteria coverage:

#	Issue Requirement	PR Coverage	Status
1	Health endpoint returns { ok: true, database: "ok" }	Check #1	✅
2	Automation sync succeeds	Check #2	✅
3	Repo listing returns repos	Check #3	✅
4	Issue sync returns syncedCount > 0	Check #4	✅
5	Issue listing returns issues	Check #5	✅
6	Board shows issues	Check #6	✅
7	Projects shows repo groups	Check #7	✅
8	Saffron heartbeat appears in Agents	Check #8	✅
9	Moving issue updates labels + audit log	Check #9	✅
10	No Prisma/BigInt/FK errors	Check #10	✅
11	MC failures don't break heartbeat	Check #11	⚠️ Skips actual failure simulation

All 11 criteria are covered, but check #11 cannot truly validate failure isolation without actually simulating MC failure (acknowledged in skip reason).

---

Evidence Provider Findings

No evidence providers configured — unable to verify runtime behavior against live endpoints.

---

Tool Harness Findings

No tool requests were executed. Security controls blocked attempts to fetch linked endpoints.

---

Unknowns / Needs Verification

1. Runtime verification impossible: Localhost and staging URLs were blocked by security controls. The script cannot be verified against actual Mission Control endpoints.
2. Version bump scope: The tech stack version updates (Next.js 14→16, Prisma v7, Node 24) are included in this PR but may be part of a separate upgrade effort. Confirm whether these version bumps are intentional for this PR or should be separated.
3. Check feat(deps)!: Update dependency next (14.2.35 → 16.2.6) #11 limitation: The heartbeat resilience check cannot be fully tested without actual failure simulation. The "verified code structure instead" skip reason is acceptable but less rigorous.

---

Summary

Blocking issue: Documentation file docs/smoke-checklist.md uses .mjs extension in examples while the actual implementation uses .cjs. This mismatch will cause user confusion and failures.

Non-blocking observations: Tech stack version updates are included but may warrant a separate PR if they are part of a broader dependency upgrade initiative.

Requested changes:

1. Update docs/smoke-checklist.md to replace all smoke-checklist.mjs with smoke-checklist.cjs
2. Verify whether tech stack version bumps (Next.js 14→16, Prisma v7, Node 24) should be in this PR or split out

[joryirving]

See automated review

[itsmiso-ai]

Closing as stale/superseded. The smoke checklist content is solid and covers all 11 acceptance criteria, but the title and body are Saffron-specific. Issue #60 (Add assignment-layer runtime smoke checklist) covers the same requirement generically.

Note: the automated review correctly identified a docs bug — docs/smoke-checklist.md references .mjs in examples while the actual script is scripts/smoke-checklist.cjs. That fix would need to land separately if someone picks up #60.