Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783

Merged
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762
Aug 18, 2026
Merged

Merge remote issue-762 branch to resolve non-fast-forward push rejection#783
joryirving merged 1 commit into
mainfrom
foreman/wl-misospace-dispatch-762/issue-762

Conversation

@itsmiso-ai

Copy link
Copy Markdown
Contributor

Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts

Fixes#762

Opened by foreman on review GO (workload wl-misospace-dispatch-762).

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 80fa7ad to 126a34bCompareAugust 18, 2026 01:05
@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 01:07

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

its-saffron[bot]

This comment was marked as outdated.

@itsmiso-ai
itsmiso-aiforce-pushed the foreman/wl-misospace-dispatch-762/issue-762 branch from 6e489df to 0534ffbCompareAugust 18, 2026 02:13
@itsmiso-aiitsmiso-ai added the needs-human Human input or decision is required. label Aug 18, 2026
@itsmiso-ai

Copy link
Copy Markdown
ContributorAuthor

⚠️ This PR fix item has been marked as BLOCKED and needs human attention.

Reason: Failing check: npm audit (failure)

Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts

Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z

@its-saffron
its-saffronBot dismissed their stale reviewAugust 18, 2026 02:24

Superseded by a newer automated review for this pull request.

its-saffron[bot]

This comment was marked as outdated.

Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to
vitest.config.ts with thresholds (75/65/70/75 statements/branches/
functions/lines) set just below the measured baseline (78.79/68.74/
72.01/80.01) so the gate enforces a floor and flags regressions
without blocking on the current snapshot. Wires a new `coverage`
job into .github/workflows/ci.yaml that runs `npm run test:coverage`
on every push and PR.
The job intentionally omits actions/upload-artifact; the previous
attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3
commit, and an earlier iteration tried a SHA that did not exist in
the action repo, causing the CI failure recorded by the AI PR
review. Storing the lcov/html report is not part of issue #762's
acceptance criteria, so we drop the step rather than retry the
same SHA-pinning dance.
Also pins deepmerge-ts ^8.0.0 in `overrides` to clear
GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma
<=7.10.0-integration-fix-prisma-publish-token.1 transitive that was
also red on the prior PR's `npm audit` job). Updates the `//`
rationale comment to mention the new pin.
Fixes#762
Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>

@its-saffronits-saffronBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Automated Review

Full PR review.

Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route

Recommendation

Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.

Change-by-Change Findings

.github/workflows/ci.yaml

  • Adds a coverage job that runs npm run test:coverage on ubuntu-latest, using the same pinned actions/checkout commit and the repository's shared ./.github/actions/setup-node action as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR.
  • The job inherits the workflow-level permissions: contents: read and the DATABASE_URL env var, consistent with the test job.

package.json

  • Adds @vitest/coverage-v8: ^4.1.8 to devDependencies. The installed lockfile version is 4.1.10, which exactly matches the vitest version already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10).
  • The only other change is a cosmetic reflow of the overrides rationale comment (em-dash formatting); no override values changed.

package-lock.json

  • Adds @vitest/coverage-v8@4.1.10 and its transitive dependencies (@bcoe/v8-coverage, ast-v8-to-istanbul, istanbul-lib-*, magicast, make-dir, supports-color, html-escaper, has-flag, std-env, js-tokens).
  • The devdevOptional flips on several @babel/* packages are a normal npm lockfile side effect of magicast (which is devOptional) depending on them; they do not change runtime behavior.
  • No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.

vitest.config.ts

  • Adds a coverage block with provider: "v8", reporters text, html, json-summary, an include/exclude set scoped to src/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75).
  • The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
  • The exclude list correctly omits test files, story files, __tests__ directories, and src/types/**.

Standards Compliance

The change follows the repository's AGENTS.md conventions:

  • CI jobs use the shared ./.github/actions/setup-node action and pinned actions/checkout commit, consistent with the existing lint, typecheck, test, and build jobs.
  • The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
  • No secrets, environment files, or build output are committed.
  • The test:coverage script already existed in package.json; this PR makes it functional rather than introducing a new script.

Linked Issue Fit

Issue PR 762 asked for:

  1. npm run test:coverage completes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.
  2. @vitest/coverage-v8 listed in devDependencies — satisfied (^4.1.8 in package.json, 4.1.10 resolved in the lockfile).
  3. CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated coverage job was added to .github/workflows/ci.yaml.

All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.

Tool Harness Findings

No tool harness findings were produced for this PR.

Unknowns or Needs Verification

  • The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
  • The coverage CI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.

Must-Check Items

  • Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is @vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installed vitest@4.1.10 peer requirement. No breaking-change risk identified.
  • Run full test suite after upgrade: The CI Tests job (npm run test) passed on the head commit, and the new Coverage job (npm run test:coverage) also passed. The full suite is green.

@joryirving
joryirving merged commit be7a3d4 into mainAug 18, 2026
8 checks passed
@joryirving
joryirving deleted the foreman/wl-misospace-dispatch-762/issue-762 branch August 18, 2026 03:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-humanHuman input or decision is required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] npm run test:coverage is broken — @vitest/coverage-v8 missing

2 participants

@itsmiso-ai@joryirving