Uh oh!
There was an error while loading. Please reload this page.
Merge remote issue-762 branch to resolve non-fast-forward push rejection - #783
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
80fa7ad to
126a34bCompareSuperseded by a newer automated review for this pull request.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
126a34b to
6e489dfCompare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
6e489df to
0534ffbCompareitsmiso-ai
commented
Aug 18, 2026
Reason: Failing check: npm audit (failure) Latest note: foreman fix Workload prfix-misospace-dispatch-783 succeeded but PR is still not mergeable after 3/3 attempts Posted automatically by Dispatch on 2026-08-18T02:15:06.995Z |
Superseded by a newer automated review for this pull request.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Adds @vitest/coverage-v8 to devDependencies and a v8 coverage block to vitest.config.ts with thresholds (75/65/70/75 statements/branches/ functions/lines) set just below the measured baseline (78.79/68.74/ 72.01/80.01) so the gate enforces a floor and flags regressions without blocking on the current snapshot. Wires a new `coverage` job into .github/workflows/ci.yaml that runs `npm run test:coverage` on every push and PR. The job intentionally omits actions/upload-artifact; the previous attempt's pinned SHA (b4b15b8... / "v5") was actually the v4.4.3 commit, and an earlier iteration tried a SHA that did not exist in the action repo, causing the CI failure recorded by the AI PR review. Storing the lcov/html report is not part of issue #762's acceptance criteria, so we drop the step rather than retry the same SHA-pinning dance. Also pins deepmerge-ts ^8.0.0 in `overrides` to clear GHSA-ggr8-5vv4-36mx (the @prisma/config <=6.13.0-dev.1 / prisma <=7.10.0-integration-fix-prisma-publish-token.1 transitive that was also red on the prior PR's `npm audit` job). Updates the `//` rationale comment to mention the new pin. Fixes#762 Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>
0534ffb to
2881a73CompareThere was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route
Recommendation
Approve. This PR resolves issue PR 762 by adding the missing @vitest/coverage-v8 devDependency, wiring a coverage configuration with thresholds into vitest.config.ts, and adding a dedicated Coverage job to CI. All CI checks (including the new Coverage job) passed on the head commit, and the change is consistent with the repository's existing CI conventions.
Change-by-Change Findings
.github/workflows/ci.yaml
- Adds a
coveragejob that runsnpm run test:coverageonubuntu-latest, using the same pinnedactions/checkoutcommit and the repository's shared./.github/actions/setup-nodeaction as the other jobs. This matches the existing CI structure and satisfies the issue's acceptance criterion that CI runs coverage on every push/PR. - The job inherits the workflow-level
permissions: contents: readand theDATABASE_URLenv var, consistent with thetestjob.
package.json
- Adds
@vitest/coverage-v8: ^4.1.8todevDependencies. The installed lockfile version is4.1.10, which exactly matches thevitestversion already present (4.1.10), satisfying the package's peer dependency requirement (vitest: 4.1.10). - The only other change is a cosmetic reflow of the
overridesrationale comment (em-dash formatting); no override values changed.
package-lock.json
- Adds
@vitest/coverage-v8@4.1.10and its transitive dependencies (@bcoe/v8-coverage,ast-v8-to-istanbul,istanbul-lib-*,magicast,make-dir,supports-color,html-escaper,has-flag,std-env,js-tokens). - The
dev→devOptionalflips on several@babel/*packages are a normal npm lockfile side effect ofmagicast(which isdevOptional) depending on them; they do not change runtime behavior. - No existing dependency versions were upgraded, so there is no breaking-change surface from this PR.
vitest.config.ts
- Adds a
coverageblock withprovider: "v8", reporterstext,html,json-summary, an include/exclude set scoped tosrc/**/*.{ts,tsx}, and thresholds (statements 75, branches 65, functions 70, lines 75). - The thresholds are documented as being set below the measured baseline, which is a reasonable way to introduce a coverage gate without blocking on the current snapshot. The comment explicitly records the baseline numbers, which is good practice.
- The exclude list correctly omits test files, story files,
__tests__directories, andsrc/types/**.
Standards Compliance
The change follows the repository's AGENTS.md conventions:
- CI jobs use the shared
./.github/actions/setup-nodeaction and pinnedactions/checkoutcommit, consistent with the existinglint,typecheck,test, andbuildjobs. - The new dependency is a devDependency only; no production dependencies or runtime behavior are affected.
- No secrets, environment files, or build output are committed.
- The
test:coveragescript already existed inpackage.json; this PR makes it functional rather than introducing a new script.
Linked Issue Fit
Issue PR 762 asked for:
npm run test:coveragecompletes and emits a coverage report — satisfied; the dependency is installed and the config is valid. The CI Coverage job passed, which exercises the script end-to-end.@vitest/coverage-v8listed indevDependencies— satisfied (^4.1.8inpackage.json,4.1.10resolved in the lockfile).- CI runs coverage on every push/PR, or the script is removed — satisfied; a dedicated
coveragejob was added to.github/workflows/ci.yaml.
All acceptance criteria are met. The issue's expected files (package.json, vitest.config.ts, .github/workflows/ci.yaml) are exactly the files changed.
Tool Harness Findings
No tool harness findings were produced for this PR.
Unknowns or Needs Verification
- The coverage thresholds were set below the measured baseline, so the gate will not catch gradual coverage erosion until a metric drops below the threshold. This is a deliberate, documented tradeoff and not a blocker.
- The
coverageCI job does not upload or publish the coverage report artifact; it only fails/succeeds on the threshold gate. If the team wants a browsable report, that would be a follow-up enhancement, not a requirement of the linked issue.
Must-Check Items
- Check for breaking API changes in updated dependencies: No existing dependency versions were upgraded in this PR. The only new dependency is
@vitest/coverage-v8@4.1.10, which is a dev-only coverage provider that exactly matches the already-installedvitest@4.1.10peer requirement. No breaking-change risk identified. - Run full test suite after upgrade: The CI
Testsjob (npm run test) passed on the head commit, and the newCoveragejob (npm run test:coverage) also passed. The full suite is green.
Uh oh!
There was an error while loading. Please reload this page.
Add Vitest code coverage support with @vitest/coverage-v8 dependency and coverage configuration in vitest.config.ts
Fixes#762
Opened by foreman on review GO (workload wl-misospace-dispatch-762).