Uh oh!
There was an error while loading. Please reload this page.
ci(release): keep feat commits on a patch bump below 1.0 - #807
Conversation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: dsv4f@https://litellm.jory.dev/v1 (openai) — primary route
Recommendation
Approve. This is a minimal, well-scoped CI configuration change that adds bump-patch-for-minor-pre-major: true to release-please-config.json. The change is consistent with the repository's actual versioning history and the PR body provides a clear rationale. No blockers or issues found.
Change-by-Change Findings
release-please-config.json (+1 line)
- Adds
bump-patch-for-minor-pre-major: truealongside the existingbump-minor-pre-major: true. - This is a valid release-please configuration option. When
bump-minor-pre-majoris true, this flag causesfeat:commits to bump the patch version instead of the minor version while the project is below 1.0. - The PR body explains the rationale: the repo has 38 consecutive patch releases on 0.5.x (going back to at least 2026-07-21), and the previous tooling bumped patch regardless of commit type. Without this flag, the first release-please run would produce 0.6.0, which would misrepresent the actual change magnitude.
- The PR body correctly notes that
bump-minor-pre-major: truestays, so a genuine breaking change still takes the minor rather than promoting to 1.0.0. - The change is a single-line JSON addition with valid syntax (verified against the full file content).
Sources
- PR PR 807 body: explains the rationale and expected effect (0.5.38 → 0.5.39).
- Git history: commit
e2d8251"ci(release): keep feat commits on a patch bump below 1.0" and prior commit0dd04c9"ci(release): maintain a standing release PR with release-please (PR 791)" — this PR builds on the existing release-please setup. - Repository impact scan:
.release-please-manifest.jsonshows current version0.5.38, confirming the project is below 1.0 and the flag will apply. - CI checks: all passed (Docker Build, Lint, Typecheck, Build, Tests, Coverage, npm audit).
Standards Compliance
This change does not touch application code, environment variables, Prisma schema, or any of the areas covered by the repository standards (AGENTS.md). The change is purely a release tooling configuration. No standards violations identified.
Unknowns or Needs Verification
- The linked source (release-please config schema at raw.githubusercontent.com) was skipped because it is not on the allowlisted hosts. However, the
bump-patch-for-minor-pre-majoroption is a well-documented release-please configuration option, and the change is consistent with the PR's stated intent. No further verification is needed for this review. - No linked issue context was provided for this PR, so no Linked Issue Fit section is applicable.
- No evidence provider findings were present in the corpus.
- No tool harness findings were present in the corpus.
Summary
bump-patch-for-minor-pre-major: trueso afeat:commit bumps the patch while the project is below 1.0.Why
The first release-please run wants 0.6.0. That is correct by conventional commits: there are no breaking markers in the unreleased range, and the bump comes entirely from five
feat:commits against tenfix:.It does not match how this repo has actually been versioned. There are 38 consecutive patch releases on 0.5.x going back to at least 2026-07-21, and those ranges contained features. The previous tooling bumped patch regardless of commit type, so release-please is the first thing here to honour
feat:as a minor.A version number should mean the same thing before and after a tooling change. Without this, 0.6.0 reads to a future maintainer as though something significant shipped, when what actually changed is the release mechanism.
bump-minor-pre-major: truestays, so a genuine breaking change still takes the minor rather than promoting to 1.0.0.Effect on the pending release
Note
Applies below 1.0 only. Whenever this repo goes 1.0, both flags stop having any effect and
feat:returns to bumping the minor, which is the desired behaviour at that point.