queue: clear next before re-enqueue - #170
Open
dacheng-gao wants to merge 1 commit into
Open
Conversation
mitchellh
commented
Jun 20, 2025
Owner
Thanks, we're definitely going to need a test to cover this. If you don't get to it I can try eventually |
dacheng-gaoforce-pushed
the
dacheng/clear-next
branch
from
September 27, 2025 10:45
be2d4d7 to
57fe5adComparedacheng-gao
commented
Sep 30, 2025
Author
ping @mitchellh |
dacheng-gaoforce-pushed
the
dacheng/clear-next
branch
from
October 1, 2025 15:35
57fe5ad to
bf51d2cComparebryanjeal added a commit
to bryanjeal/libxev
that referenced
this pull request
Jun 27, 2026
…xt in submit Bug mitchellh#209: kqueue tick(0) EV_DELETE flush - Changed early exit condition from 'if (wait == 0) break' to 'if (wait == 0 and changes == 0) break' so pending EV_DELETE kevent changes from the event-processing loop are flushed before tick(0) returns. Bug mitchellh#170: rearm state correction - When a non-kqueue completion (close, shutdown, threadpool fallback) returns .rearm, set flags.state to .adding before pushing to the submissions queue. Previously .dead state caused submit() to route through stop_completion (cancel) instead of start() (resubmit). Issue mitchellh#169: defensive next-pointer clear in submit() - Explicitly clear c.next before push to completions queue when processing kevent-returned events in submit(). This prevents an assertion failure if a completion is present in multiple queues concurrently (race condition).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probablly fixes#169