Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalog edits currently require publishing aimodels to npm or managing a sibling-repository link before AIWrapper can use them. This replaces that dependency with an editable
aimodels/Git submodule, pinned to upstream commit5d646aff26f93fc8b3304f2645d99827e45601ba(package version 0.7.0).The build validates and compiles the upstream catalog, then ships its JavaScript, declarations, and MIT license inside AIWrapper. Consumers continue importing
models,Model, and other catalog APIs fromaiwrapper, without fetching aimodels or needing Git. Developers can editaimodels/data/oraimodels/js/src/and runnpm run aimodels:build; the playground uses that generated catalog too. A separately installed aimodels package now has its own catalog instance and class identity.Automatic updates
publish.ymlat the tag, since GITHUB_TOKEN-created tag pushes do not trigger another workflow. Verify tag/version agreement, skip already published versions, and support recovery when dispatch or publication fails.CI initializes submodules. The former npm-link scripts and dependency-update workflow are replaced, and developer documentation covers editing and committing in both repositories. Website automation is outside this change.
Validation
Verified from a fresh clone with the proposed patch applied, submodules initialized from GitHub, and clean dependency installations:
npm run check: 115 upstream catalog tests, 186 AIWrapper tests, and a packed npm consumer runtime/TypeScript check.npm run check:playground: zero type-check errors or warnings, 35 tests, and a production browser build.actionlint, JavaScript syntax checks, andgit diff --checkpassed.The automation becomes active after merge. npm must trust
mitkury/aiwrapper/publish.ymlwith direct publishing allowed. Inspection of that account setting required npm MFA, so it has not been verified in this session. No npm release was performed.