Skip to content

Clamp the packet count between 0x8000 and 0xFFFF to eliminate duplicate packets - #486

Merged
felipediel merged 1 commit into
mjg59:masterfrom
felipediel:patch-29
Jan 9, 2021
Merged

Clamp the packet count between 0x8000 and 0xFFFF to eliminate duplicate packets#486
felipediel merged 1 commit into
mjg59:masterfrom
felipediel:patch-29

Conversation

@felipediel

@felipedielfelipediel commented Nov 28, 2020

Copy link
Copy Markdown
Collaborator

We still have this problem. I made a mistake there, the solution doesn't work because when we send the authentication packet the device returns the packet count we sent (and not the previous count, in which we are interested).

The goal here is to start over based on a discovery made by @hogi1200. When we send a packet count between 0x8000 and 0xFFFF the device doesn't have problems to eliminate duplicate packets, so this is definitely the way to go.

@felipediel
felipediel marked this pull request as draft November 28, 2020 02:03
@felipediel
felipediel marked this pull request as ready for review November 28, 2020 02:07
@felipediel
felipediel marked this pull request as draft November 28, 2020 02:43
@felipediel
felipediel marked this pull request as ready for review November 28, 2020 03:09
@felipediel
felipediel marked this pull request as draft November 28, 2020 04:18
@felipedielfelipediel changed the title Fix packet counter restorationClamp the packet count between 0x8000 and 0xFFFF to eliminate duplicate packetsNov 29, 2020
@felipediel
felipediel marked this pull request as ready for review November 29, 2020 17:56
@felipedielfelipediel mentioned this pull request Dec 3, 2020
@felipediel
felipediel merged commit 93e7d21 into mjg59:masterJan 9, 2021
@felipedielfelipediel mentioned this pull request Jan 20, 2021
Merged
felipediel added a commit to felipediel/python-broadlink that referenced this pull request Jan 29, 2021
felipediel added a commit to felipediel/python-broadlink that referenced this pull request Jan 29, 2021
@RestOp

Copy link
Copy Markdown

Hello,

was it really fixed (and realeased), because i have the problem till now... Any suggestions?

@RestOp

Copy link
Copy Markdown

I have already tried to use this method home-assistant/core#47779 (comment) but no luck.
I use last HA in docker.

@felipediel

Copy link
Copy Markdown
CollaboratorAuthor

Are you using custom components? If so, they might be preventing python-broadlink updates.

The changes were tested with the samples provided and they worked. Already released.

@RestOp

Copy link
Copy Markdown

Thanks for reply!
Whitch custom components do you mean? If broadlink, then i use only official integration. I was also looking for non-official one, that will work for me, but have not found.

It seems that after update home-assistant/core#47779 (comment) my HA just do not start and i need to reboot it one more time to make it start (i think then integrations resets to default).
In my actual HA version (Home Assistant 2023.1.2, Supervisor 2022.12.1, Frontend 20230104.0 - latest) i have compoment version 18.3, here under the link home-assistant/core#47779 (comment) is version 18.0. I also tried "pip3 install git+https://github.com/felipediel/python-broadlink.git@patch-29 --force-reinstall --no-deps" (that works for me before) seems they all incompatible to my HA.

I ask for your help!

PS
I am despaired that i can do nothning, spent a lot of time trying to make it work and thinking about to change all my 25 sockets, baucause of this :-((( But as you can understand it is a little bit rough to change them only because of software problem.
I do not how, but before version HA 114 or 118 it worked perfekt for me for about one year wihtout any bugs. Then i tried a lot of HA insallations on differentharwdare (from Rpi 4 till i7 NUC).

@RestOp

Copy link
Copy Markdown

ia hev already tried to relearn the codes. But also no luck.
Here are some samples of this codes:
`socket_3_1_on:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwgKCCsIKwgJCSoICggrCAoICggrCCsICQkqCQkJCQgrCAoIKwgKCCoJCggqCAoIKwgKCCoJCggqCAoIKwgKCCsICggrCAoIKggrCAoICggrCAoIKgkJCCsIKwgKCAABXQhUCCsICggJCSoJKggKCAoIKwgrBwoICggrCAoIKwgKCCoJCQkqCAoIKwgrCAoIKggKCSoICggKCCsIKwgKCCoICgkKBysICggrCAoIKwgKCCsICggqCAoIKwgKCCsICggqCQkIKwgKCCsICggqCSoICggKCCsICggrCAoIKgkqCAoIAAFeCFMJKggKCQkIKwgrCAoICggrCCsICggKCCsICgcrCQkIKwgKCCsICggrCCsICggqCQoIKggKCQoHKwkqCAoIKwgKCAoIKwgKCCsICggrCAoIKwgJCSoJCQgrCAoIKwgKCCsICggrCAoIKwgKCCsIKgkJCQkJKwcKCCsJCQgrCCsICggAAV4IVAgqCQoICggrCCsHCgkJCSoIKwgKCAoIKwgKCCsICggrCAoIKwgKCCsIKwgKCCsICggrCAoICggrCCsICggqCQkJCgcsCAkJKgkJCCsICggrCAoIKwgKCCsICggrCAoIKwgJCSoJCgcrCAsIKggrCAoICggrCAoIKwgKCCsIKwgKCAABXQhUCSoICggKCCsIKwgKCAoIKwgrCAoICggrCAoIKwgJCSoJCggqCQkILAgqCAoIKwgKCCsICggKCCsIKwgKCCsICggKCCsICggrCAoIKwgKCCoJCggrCAkILAgKCCsICQgrCAoIKwgKCCsICggrCCsICggKCCsICggrCAoIKwgrCAoIAAFdCVQIKgkKCAkILAgqCAoJCQkrCCoJCggKCCsICggrCAoIKwgKCCsICggrCCsICggrCAoIKwgKCAoIKwgrCAoIKwgKCAoIKwgKCCsICggrCAoIKwgKCCsICggrCAoIKwgKCCsICggrCAoIKwgKCCsIKwgKCAoIKwgKCCsICggrCCsICggAAV4IVAgqCQkJCQkrCCsICQkJCSoJKwgKCAkJKgkJCSsHCwgrCAoHLAgKCCsIKgkKCCsICQkrCAoICggrCCsICggrCAoICggrCAoIKwgKCCoJCggqCQoIKwgKCCsICggrCAoIKwgJCSsICggrCAoIKwgrCAoICggrCAoIKwgKCCsIKwgKCAAF3AAAAA=

socket_3_1_off:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgKEAwgKBywHLAgKCCsICggrCAoICggrCCwHCggrCAsHCwcrCQoHLAgKBysICggrCAoIKwgKBywICggrCAoHLAgJCCsICggrCAoHKwgKCCsICggrCAoIKwgKCCsIKwgKCAABXQhTCSsHCwcLBysJKwcLCAoHLAgqCAsICgcrCQoHKwgKCCsICggrCAoIKwcrCAoIKwgKCCsHCwgKBysIKwgKCCsICggKCCsICQgrCAoIKwgKCCsICggrBwoIKwgLBysICggrCAoIKggKCCsICggrCAoIKwgKCCoJCgcrCAoIKwgrCAoIAAFdCFMJKggKCAoIKwgrCAoICggrCCsICgcLBysICggrCAoIKwgKCCsICwcrCCsICggrBwsIKggKCAsHKwgrCAoIKwgKCAoIKwgKBysICggrCAoIKwcLBysJCQgsBwoIKwgKCCsICggrCAoIKwgKCCsICggrCAoIKgkKCCsICgcsBysICwcAAV4HVAgrCAoICggrCCoICwcLBysIKgkKCAoHKwgKCCsICggrCAoIKggKCCsIKwgKCCoICwgqCAoICggrCCsHCwcrCAoICggrCAoIKggKCCsICggqCAoIKwgKCCsICgcrCAoIKwgJCSoICggrCAoIKggKCCsICggqCQkIKwgKCCoJKggKCAABXAlTCCsICggKBysIKwgKCAoIKgkqCAoICggrCAoIKggKCCsICggrBwsHLAcrCAoIKggLCCoICggKCCsIKggKCCsICggKCCsHCggrCAoIKwgJCCsICggrCAoIKggKCCsICgcrCAoIKwgKBysICggrCAoIKwcKCCsICggrBwoIKwgrBwsIAAFcCFQIKggKCAoIKwgrBwsHCwgqCCsICggKBysICggrCAoHKwgKCCsICggrBysICggrCAkIKwgKCAoIKwcrCAoIKwgKCAkJKggKCCsICgcrCAsHKwgKCCsHCggrCAoIKggKCCsICggrBwsHKwgKCCsICgcsBwoIKwgKCCsHCwcrCCsHCwcAAV4HVAgrCAoHCwcrCCsHCggLBysIKwcLCAoHKwgKCCsICggqCAoIKwgKBysIKwgKCCoICggrCAoICgcrCCsICggqCAsHCggrCAoIKwcLBysICggrCAkIKwgKCCoICwcsBwoIKwcKCCsICggrBwsHKwgKCCsICQgrCAoIKwcKCCsIKwgJCAAF3AAAAA=

socket_3_2_on:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwkJCSoIKggKCCoJCQkpCQkJCQgqCSoICggqCQkICggqCAkJKgkJCCoJCQgrCAkJKQkJCSoICggqCAoIKggKCCoJCQgqCQkIKwgqCAoICggqCAoIKggqCQkJCQgrCAABWwlTCCoJCQgKCCoJKggKCAkJKQkqCAoICQkqCAoIKggKCCoJCQgqCQkJKggqCAoIKggKCCoJCQgKCCoJKggJCSoICggJCSkJCQkqCAoIKggKCCoJCQgrCAkJKggJCSoICQkqCAoIKgkJCCoJCQgqCSkJCQkJCSkJCQkqCCoICggKCCoIAAFcCVMIKggKCAkJKggqCQkICggqCSoICQkJCCoJCQkqCAkJKggJCSoICQkqCSkJCQkpCQkJKggKCAkJKggqCQkJKQkJCQkIKgkJCCoJCQkpCQkJKggJCSoICggqCAoIKgkJCCoJCQgqCQkIKwgJCSoIKggKCAoIKggKCCoJKggJCQkIKgkAAVsJUwkpCQkJCQgqCSoICQkJCSkJKggKCAoIKgkJCCsICQgqCQkJKQkJCSoIKggKCCoICgkpCQkICggqCSkJCQkqCAoICggqCAoIKgkJCCoJCQgqCQkIKgkJCSkJCQkqCAkJKggJCSoICggqCAkJKgkqCAkJCQkpCQkJKggqCQkICQkqCQABWwlSCSoICggKCCoIKgkJCQkIKgkqCAkJCQkqCAoIKggJCSoICggqCAoIKgkqCAkJKggKCCoICggKCCoIKgkJCCoJCQkJCCoJCQgrCAkJKggJCSkJCQkqCAoIKggKCCoJCQgqCQkIKgkJCSoICQkqCCoJCQgKCCoJCQgqCSoICQkJCSoIAAFcCFMJKggJCQkIKwgqCAoICQkqCCoJCQgKCCoJCQgqCQkJKQkJCSkJCQkqCCoICggqCQkIKgkJCQkIKgkqCAoIKggKCAkJKggJCSoICggqCQkIKgkJCCsICQkqCAkJKggJCSoICggqCAoIKgkJCCoJKQkJCQkJKggJCSoIKggKCAoIKgkAAVsJUwgqCAoJCAkqCCoJCQkJCCoJKggJCQoIKggKCCoICggqCAoIKgkJCCoJKggJCSoICggqCAoICggqCCsICQkpCQkJCQkpCQkJKggJCSoICQkqCAoIKgkJCCoJCQkpCQkIKgkJCSoICQkqCAkJKggqCQkJCQgrCAkIKgkqCAoICQkqCAAF3AAAAAA=

socket_3_2_off:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwgJCCoJKggKCCoICggqCAkJCggqCCoICggqCQkICggqCQkIKggKCCoJCQgqCQkIKgkJCCoJCQkpCQkJKQkKCCoICQkpCQkJKggJCSoICggqCAkJKggqCQkICggqCAABXAhTCSoICggJCCoJKggKCAkJKQkqCAoICggqCAoIKggKCCoICggqCAoIKgkpCQkJKQkJCSkJCQkJCCoJKggJCSoICggJCSoICQkqCAoIKggKCCoICggqCAoIKggKCCoJCQgqCAoIKgkJCCoJCQgqCQkIKgkJCCoJCQkpCSoICQkJCSkJAAFbCVMIKgkJCQkIKgkqCAkJCQgqCSkJCggJCSoICQkpCQkJKggJCSoICQkqCCoICggqCQkIKgkJCAoIKgkpCQkJKggJCQkIKgkJCSkJCQkqCAkJKggJCSkJCQkqCAkJKggJCSoICggqCAoIKggKCCoJCQgqCQkIKgkJCCoJKggJCQkJKggAAVsJUwgqCQkICggqCSkJCQkJCCoJKggKCAkIKwgJCCoJCQkpCQkJKQkJCSoIKggJCSoICggqCAoJCQgqCCoJCQkqCAkJCQgqCQkIKgkJCCoJCQkpCQkJKQkJCSoICQkqCAkJKggKCCoICggqCAoIKggKCCoJCQgqCQkIKgkpCQkJCQgqCQABWwlTCCoICggKCCoIKgkJCQkIKgkpCQkJCQgqCQkJKQkJCCsICQkqCAkJKggqCAoIKggKCCoJCQgKCCoIKgkJCSkJCggJCSkJCQgqCQkJKQkJCSoICQkqCAkJKQkJCSoICQkqCAoIKgkJCCoICggqCAoIKgkJCCoJCQgqCSkJCggJCSkJAAFbCVMIKgkJCAoIKggqCQkJCQgqCSoICQkJCCoJCQkqCAkJKggJCSoICQkqCCoICggqCAoIKgkJCAoIKgkpCQkJKQkJCQkIKgkJCCoJCQkpCQkJKQkJCSoICQkqCAkJKggKCCoICggqCQgJKgkICSoICggqCQkIKgkJCCoJKggJCQkIKgkAAVsJUwgqCQkJCQgqCSkJCQkJCCoJKQkKCAkIKgkJCSkJCQkqCAkJKggJCSoIKggKCCoJCQgqCQkJCQgqCSkJCQkqCAkJCQkqCAkJKggJCSoICQkqCAoIKggKCCoICggqCAoIKgkJCCoJCQgqCQkIKwgJCSkJCQkpCQkJKggqCAoICQkqCAAF3AAAAAA=

socket_3_3_on:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwgJCCsHKwgKCCoICggqCAoICQkqCCoICggqCQoHCggqCQkIKwgJCCsICgcrCAkIKwgKCCoICggqCAoIKggKCCoICggrCAkIKwgqCAoICQkqCAkJKggqCAoIKwcKCAABXAhTCSoICggKBysIKggKCAkJKggqCQkICggqCAoIKgkJCCsICQgqCQoHKwgqCAoIKggKCCoICggKCCoIKgkJCSoICQkJCCsICQgrCAkIKwgKCCoICQkqCAoIKggKCCoICggrBwoIKwcKCCoJCQgrBysICQkJCCsICQgrCCoICggqCAoIAAFcCFMJKggKCAkIKgkqCAoICQkqCCoICggKCCoICggqCAoIKgkJCCoICggrBysICQkqCAoIKggKCAoIKggqCAoIKwgJCAoIKggKCCoJCQgrCAkIKgkJCCsICQgrCAoIKggKCCoICggqCAoIKggKCCoIKgkJCAoIKwcKCCoJKggKCCoICggAAVwIUwgqCQoHCggqCSoICggJCCsIKggKCAkJKggKCCoICggqCAoIKggKCCoJKggKCCoICggqCAoICggqCCoICggrBwoICggqCAoIKgkJCCoICggqCQkIKwgJCCsICggqCAoIKggKCCoICggqCAoIKggrCAkICggqCQkIKgkqCAoIKggKCAABXAhTCCsICQkJCCoJKggKCAkJKggqCAoICQkqCAoIKggKCCoICggqCAoIKwcrCAoHKwgKCCoICggJCCsIKggKCCoICggKCCoICggrBwoIKgkJCCsHCggrCAoHKwgKCCoICQkqCAoIKggKCCoICggqCCsICQgKCCoJCQgrCCoICggqCAoIAAFcCFMJKQkJCQkIKwcrCAoICQgrCCoICggKCCoICggqCAoIKggKCCoJCQgqCSoICggqCAoIKggLBwoIKggqCAoIKgkJCAoIKgkJCCsICQgrCAkIKwgKCCoICggqCAoIKggKCCoICggqCAoIKggKCCoJKggKCAkIKwgJCSoIKggKCCsHCggAAVwIVAgqCAoICQgrCCoICggKCCoIKgkJCAoIKwgJCCsICQgqCQkIKwgJCCsIKggKCCoICggrBwoICggqCCoJCQkqCAoICgcrCAkJKggKCCoICQkqCAkJKwcKCCoICggqCAoIKggKCCsHCggrCAoHKwgqCAoICQkqCAoIKggqCAoIKggKCAAF3AAAAAA=

socket_3_3_off:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwgKCCsIKggKCCoICggrCAoICQgrCCoICggrBwoICggqCAoIKwgKCCoICggqCAoIKggKCCsICggqCAoIKggKCCoJCQgrCAkJKggKCCoICggqCQkIKgkqCAoIKggKCAABXAhUCCoICggKCCoIKwgKCAkIKwgqCAoICggqCQkIKgkJCCsICgcrCAoIKgkqCAoIKggKCCoICggKCCoJKggKCCoICggKCCoICggqCQkIKwgJCCsICQkqCAoIKggKCCoJCQkqCAoIKgkJCCoJCQgrCAkJKggKCCoICggrCCoICggrBwoIAAFcCFQIKggKCAkJKggqCAoICggqCSoICggKCCoICggrBwoIKgkJCCoJCQgrCCoICggqCAoIKgkJCQkIKgkqCAoIKggKCAoIKggKCCoJCQgrCAkIKwgJCSoICggqCQkIKgkJCCsICQgrCAoIKggKCCoICggqCAoIKwgJCSoIKggKCCoJCggAAVwIUwgqCQkJCQgrCCoICggKCCoIKggKCAoIKwgJCCoJCggqCAoIKggKCCoJKggKCCoICggrCAkICggrCCoICggqCAoICggqCQkIKwgJCCsICggqCAoIKggKCCoJCQgqCQkJKggKCCoICggrCAkIKgkJCSoICggqCAoIKggrCAkJKggKCAABXAhTCSoICggJCCsIKggKCAoIKgkqCAoICQkqCAoIKggKCCoJCQgqCQkJKggqCAoIKgkJCSoICggJCCsIKggKCCoJCQkJCCsICQgrCAoIKggKCCoICggqCQkIKwgJCSoICggqCAoIKwgJCCsICQgrCAoIKggKCCoICggqCSoICggqCAoIAAFcCFQIKggKCAoIKggqCQkICggrCCoICggKCCoICggqCQkIKgkJCCsICggqCCoJCQkqCAoIKggKCAoIKggrCAkJKggKCAkJKggKCCoICggqCAoIKgkJCCsICgcrCAoIKggKCCoJCQgrCAkJKggKCCoICggqCQkIKgkJCCsIKggKCCoJCQgAAVwJUwgqCAoICggqCSkJCggJCSoIKggKCAoIKgkJCCsICQkqCAkJKggKCCoJKggKCCoICggqCAoICggrCCoICggqCAoICggqCAoIKgkJCCsICQgrCAoIKggKCCoICggqCQkIKgkJCSoICggqCAoIKgkJCCsICQgrCAoIKggrCAkJKggKCAAF3AAAAAA=

socket_3_4_on:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwkJCCsIKgkJCCoJCQkqCAoICQgrCCoICggqCQkICggrCAkIKwgJCSoICggqCAoIKggKCCoJCQgrCAoIKggKCCoICggqCQkIKgkqCAoICggqCCoJCQgKCCoJCQgqCQABWwlTCCsICQkJCCsIKggKCAkJKggqCAoICggqCQkIKgkJCCsICQkqCAoIKggqCQkIKwgKCCoICggJCSoIKgkJCSoICggJCSkJCQkqCAoIKggKCCoJCQgqCQkIKwgJCSoICggqCAoIKggKCCoJCQgqCSoICggJCSoIKggKCAoIKgkJCCoJAAFcCFMIKgkJCAoIKwgqCAoICQkqCCoICggKCCoJCQgqCQkIKwgJCSoICQkqCCoJCQgrCAkJKggKCAoIKggqCQkIKwgJCQkIKgkJCSkJCQkqCAkJKggJCSoICggqCQkIKgkJCSoICQkqCAkJKggKCCoIKgkJCAoIKwgqCAkJCQkqCAkJKggAAVwIUwkqCAkJCQkqCCoICggJCSoIKgkJCQkIKwgJCCoJCgcrCAoIKggKCCoIKwgJCSkJCQkqCAoICQkqCCoICggqCQkJCQgrBwoIKgkJCCsICQkqCAoIKggKCCoICggqCAoIKwgJCCsICQgrCAkJKggqCAoICggqCSoICQkJCCoJCQkqCAABXAhTCCoJCQkJCCoJKggKCAkJKggqCAoICggqCQkIKgkJCCsICQkqCAkJKggqCAoIKgkKBysICQkJCCoJKggKCCoICggKCCoICggqCAoIKgkJCCsICQkqCAoIKggKCCoICggqCQkIKgkKByoJCQgqCSoICggKCCoIKgkJCQkIKgkJCCsIAAFcCFMIKgkJCQkIKgkqCAkJCQkqCCoICggKCCoICggqCAoIKgkJCCsICQgrCCoJCQgqCQkIKwgJCQkIKwgqCAoIKggKCAoIKggKCCoICggqCQkIKgkJCCsICQkqCAkJKggKCCoICggqCQkIKgkJCCsIKggKCAoIKggqCAoICggqCQkIKgkAAVwIUwgqCQkJCQgqCSoICggJCCsIKggKCAkJKggKCCoICggqCQkIKgkJCCoJKggKCCoICggqCQkJCQgrCCoICggqCAoICggqCAoIKggKCCoICggqCQkIKgkJCCsICQkqCAoIKggKCCoICggqCQkIKgkqCAoICQkqCCoICggKCCoICggqCQAF3AAAAAA=

socket_3_4_off:
sequence:
- service: remote.send_command
data:
entity_id: remote.broadlink_rm_pro_remote
command: b64:sgGEAwkJCCsIKggKCCoJCQgrCAoICQkqCCsHCggrCAoICggqCAoIKgkJCCsICQgrCAoIKgkJCCsICQgrCAoIKggKCCsICQgrCAoIKggKCCsHCggrCCoICggKCCoICggrCAABXAhTCSoICggJCCsIKggKCAoIKgkqCAoICQgrCAoIKggKCCoJCQgrCAoIKggrCAkJKggKCCoICggKCCsIKggKCCoJCQkKBysICQkqCAoIKgkJCCsICggqCAoIKgkJCCsICQkqCAkJKggKCCsHCggrCAoIKggKCCoJKggKCAkJKggKCCoIAAFcCVMIKwcKCQkIKwgqCAoICggrCCoICggJCSoICggqCAoIKwgJCSoICQkqCCsICQkqCAoIKggKCAoIKgkqCAoIKggKCAoIKgkJCCsICQkqCAoIKggKCCsICQgrCAkIKwgKCCoICggqCQkIKwgJCSoICggqCAoIKwgqCAoICggqCAoIKgkAAVwIUwgrCAoHCggrCCoICggKCCoIKwgKCAkIKwgKCCoICggqCQkIKgkKBysIKggKCCoJCggqCAoICggqCCoJCQkqCAoICQkqCAkJKggKCCsICQgrCAoHKwgKCCoICggqCQkIKwgJCSoICggqCAoIKgkJCCsICggqCCoJCQkJCCsICQgrCAABXAhUCCoICggJCSoIKgkJCQkIKgkqCAoICggqCAoIKgkJCCsICQkqCAoIKggrCAoIKggKCCoICggKCCoJKggKCCoICggKCCoJCQgrCAkIKwgKCCoICggqCQkIKwgJCCsICggqCAoIKgkJCCsICQgrCAoIKggKCCoJKggKCAoIKggKCCoIAAFdCFMIKgkJCAoIKwgqCAoICggqCCsHCggKCCsICQkqCAoIKggKCCsHCggrCCoICggrCAkJKggKCAkJKggrBwoIKwgKCAoHKwgKCCoICggrCAkIKwgJCCsICggqCAoIKggKCCsICQgrCAoIKggKCCoJCQgrCAoHKwgrBwoICggqCQkIKwgAAVwIUwkqCAoICggqCCoJCQkJCCsIKggKCAoIKggKCCoJCQgrCAoHKwgKCCoIKwgKCCoICggqCAoICggqCSoICggqCAoICggqCAoIKwgKBysICggqCAoIKgkJCCsICQkqCAoIKggKCCoICggrCAkJKggKCCoJCQgqCSoICggKCCoICggqCAAF3AAAAAA=
`

@RestOp

Copy link
Copy Markdown

It works but very slow on this commands (about 2-4 sec on each) and then crushes
image

@felipediel

Copy link
Copy Markdown
CollaboratorAuthor

Have you tried a clean installation with the latest python-broadlink? It should work by default, no tweaks

@felipediel

Copy link
Copy Markdown
CollaboratorAuthor

Looks like a network issue

@RestOp

RestOp commented Jan 12, 2023

Copy link
Copy Markdown

I have tried to remove component
image
restart HA and then install it
image

Please could you send me a link how to install latest python-broadlink?

@felipediel

Copy link
Copy Markdown
CollaboratorAuthor

pip3 install broadlink

@RestOp

Copy link
Copy Markdown

Thanks!
Will try now to completely remove component, install it and install "pip3 install broadlink"

@RestOp

Copy link
Copy Markdown

Here the output
image

@RestOp

RestOp commented Jan 12, 2023

Copy link
Copy Markdown

I have noticed also one thing. I have turned off office light group (total 4 sockets). They turned off (in about 5-7 secs), but then broadlink countinue to send for about 10-15 sec any signals (LED blinks).

@RestOp

Copy link
Copy Markdown

I could think that my broadlink makes problem, but if i use native app or old HA version - is everything ok!

@RestOp

Copy link
Copy Markdown

After that patch it was ok #454
But now i can not use it. Maybe new one?

@felipediel

felipediel commented Jan 13, 2023

Copy link
Copy Markdown
CollaboratorAuthor

I tested your codes with my RM pro and they work fine. It is definitely a problem with your installation.

I noticed that you ran pip3 install broadlink without activating the hass virtual environment. Try that first and run the command again.

@RestOp

Copy link
Copy Markdown

I tested your codes with my RM pro and they work fine. It is definitely a problem with your installation.

I noticed that you ran pip3 install broadlink without activating the hass virtual environment. Try that first and run the command again.

I would try to activate it, but how can i do it?

@RestOp

RestOp commented Jan 13, 2023

Copy link
Copy Markdown

I have done. But it it cleat that it was just warning and it gave nothing.
image

I have installed the sniffer and what i see - I have run just once "ON" for 4x sockets together, but it was sended from broadlink three times!
image

@felipediel

Copy link
Copy Markdown
CollaboratorAuthor

You still have the previous version. You must update this module in the virtual environment used by Home Assistant or, in case you are using Docker:

  1. Open Home Assistant and install "SSH & Web Terminal" add-on
  2. Disable Protection mode
  3. Connect to the device via SSH and install the patch:
ssh USER@IPADDRESS
docker exec -it homeassistant /bin/bash
pip3 install broadlink
  1. Restart the server.

If you have any question, please forward to the appropriate channels on discord or the Home Assistant community.

@RestOp

Copy link
Copy Markdown

Hello,

i made directy what you have written and i got.
Strange i got the same.
image

Please let me know witch version must be?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@felipediel@RestOp