Improve RM4 communication - #490
Merged
Merged
Conversation
felipediel
marked this pull request as draft
December 8, 2020 05:37
felipedielforce-pushed
the
cleanup-rm
branch
2 times, most recently
from
December 14, 2020 05:08
eedcaf0 to
0b46909Comparefelipediel
marked this pull request as ready for review
December 16, 2020 05:30
Merged
felipediel added a commit
to felipediel/python-broadlink
that referenced
this pull request
Jan 29, 2021
felipediel added a commit
to felipediel/python-broadlink
that referenced
this pull request
Jan 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
When we added the RM4 class we didn't know the meaning of the new two bytes attached to the left of the payload, so we added them as constants, exactly as they appeared in the packets.
Although this implementation has served us relatively well so far, it is a poor implementation. These bytes represent the payload length. We are sending incorrect values for variable-sized packets. In rm4.send_data(), for example, we are prefixing the packets with the constant 0xda, or 218. If the packet is larger than 218 bytes, overflow information is lost.
Proposed changes