feat: add ty type checking to template - #21
Merged
Merged
Conversation
- Add locked ty development dependency to generated projects - Run ty checks in template and generated-project CI workflows - Document ty usage in the project README
mjun0812
commented
Sep 2, 2026
mjun0812
left a comment
OwnerAuthor
There was a problem hiding this comment.
Codex PR Review
Summary
This pull request adds ty as a locked development dependency, runs type checking in both template verification and generated-project CI, and updates the repository documentation. No blocking findings were confirmed. The Contract axis was skipped because no spec source was available.
Verdict
APPROVE
Findings
N/A
Reviewed by Codex at de8d645
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview and Background
Generated projects now include Astral's stable
tytype checker as a locked development dependency and run it in continuous integration. Previously, template CI validated formatting, linting, and tests but did not perform static type checking.Related Issues
None.
Implementation Approach
Add
tyto the existing development dependency group and regenerate the template lockfile so generated projects install the exact checker version. Run the same frozen command in both the generated-project verification workflow and the generated template workflow, keeping local and CI checks aligned.Changes
ty>=0.0.77and its locked resolution to the template.uv run --frozen ty checkto template CI and generated-project verification CI.tywas not stable.Impact
Generated projects gain a static type-checking step in CI and an additional development dependency. Runtime behavior, Docker configuration, and existing formatting, linting, and test workflows are unchanged.
Validation Results
Validated a generated project from this branch with:
All checks passed, including
tyreportingAll checks passed!and pytest reporting 2 passed tests.