Uh oh!
There was an error while loading. Please reload this page.
Prepare for 2.0 (finalize deprecations) - #433
Merged
Merged
Conversation
Breaking change
johnslavikforce-pushed
the
b/bump-major-version
branch
from
November 29, 2025 15:40
fbe01d7 to
02cf71fComparepawamoy
reviewed
Nov 30, 2025
pawamoy
left a comment
Member
There was a problem hiding this comment.
Yes, that's a good idea. Since we're going to bump the major version for the griffe/griffelib split, lets remove deprecated code at the same time 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pawamoy
commented
Nov 30, 2025
Member
So you ran |
johnslavik
commented
Nov 30, 2025
MemberAuthor
Precisely! |
johnslavik
marked this pull request as ready for review
November 30, 2025 19:08
This was referenced Nov 30, 2025
pawamoy
commented
Dec 2, 2025
Member
Wait I'll commit a few other changes here. |
johnslavik
commented
Dec 2, 2025
MemberAuthor
LGTM |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #431 migration will be way less pain if we cleanup old deprecations first.