Skip to content

Add nlp blogpost - #23

Open
ehoelzl wants to merge 9 commits into
masterfrom
Add-NLP-blogpost
Open

Add nlp blogpost#23
ehoelzl wants to merge 9 commits into
masterfrom
Add-NLP-blogpost

Conversation

@ehoelzl

@ehoelzlehoelzl commented Oct 7, 2020•
edited
Loading

Copy link
Copy Markdown

Closes#15

martinjaggi
martinjaggi reviewed Oct 8, 2020
View reviewed changes
Comment thread_posts/2020-10-02-nlp-translation.md Outdated
tvogels
tvogels reviewed Oct 12, 2020
View reviewed changes

@tvogelstvogels left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ehoelzl, @martinjaggi asked me to go over the blog post and leave a review.
Interesting results. I also like the overall tone of the blog post.
My comments are a mix of reformulation suggestions to make things more concise, terminology confusion, and a thing or two about the presentation of the results. Hope this is helpful.

Comment thread_posts/2020-10-02-nlp-translation.md Outdated
Comment thread_posts/2020-10-02-nlp-translation.md Outdated
Comment thread_posts/2020-10-02-nlp-translation.md Outdated
Comment thread_posts/2020-10-02-nlp-translation.md Outdated
Comment thread_posts/2020-10-02-nlp-translation.md Outdated
Comment thread_posts/2020-10-02-nlp-translation.md
Comment thread_posts/2020-10-02-nlp-translation.md
Comment thread_posts/2020-10-02-nlp-translation.md
Comment thread_posts/2020-10-02-nlp-translation.md Outdated
Comment thread_posts/2020-10-02-nlp-translation.md
@ehoelzl
ehoelzl requested a review from tvogelsOctober 30, 2020 13:28
@ehoelzl

ehoelzl commented Feb 26, 2021

Copy link
Copy Markdown
Author

@martinjaggi@tvogels Could you review the updates please ? Thanks

martinjaggi
martinjaggi reviewed Feb 26, 2021
View reviewed changes
Comment thread_posts/2020-10-02-nlp-translation.md
![test]({{ site.baseurl }}public/images/blog/2020-10-02-nlp-translation/task4b_loss_ratio_prices.png)
*Step times for Transformer*
<a href="{{ site.baseurl }}public/images/blog/2020-10-02-nlp-translation/task4b_step_shares.png" data-lightbox="task4b_step_shares" data-title="Step shares for Transformer">
*Step shares for Transformer*

@martinjaggimartinjaggiFeb 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a 'step share' a communication step? maybe better to call it that in the text?

@martinjaggi

martinjaggi commented Feb 26, 2021 via email

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinjaggimartinjaggimartinjaggi left review comments
@mmilenkoskimmilenkoskiAwaiting requested review from mmilenkoski
@tvogelstvogelsAwaiting requested review from tvogels

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Blogpost about NLP Results

3 participants

@ehoelzl@martinjaggi@tvogels