Skip to content

feat!: parse % Occupied from InterOp summary - #95

Merged
dhaupt88 merged 1 commit into
masterfrom
parse-percent-occupied
Sep 14, 2026
Merged

dhaupt88 merged 1 commit into
masterfrom
parse-percent-occupied

Conversation

@dhaupt88

@dhaupt88 dhaupt88 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Patterned flowcells (NovaSeq X Plus, MiSeq i100) prescribe cluster locations, so density says nothing about how well the flowcell was loaded. % Occupied does: the share of wells holding a cluster.

The value is already part of the InterOp summary CSV, it was just discarded during parsing. Unpatterned flowcells report nan, so RunResult::percentOccupied is nullable.

Taken from the Non-indexed run-level summary row, where the value is identical across reads.

BREAKING CHANGE: RunResult::__construct() takes percentOccupied as a required third argument.

Patterned flowcells prescribe cluster locations, so occupancy rather than
density measures how well a flowcell was loaded. Unpatterned flowcells
report "nan", which parses to null.
@github-code-quality

Copy link
Copy Markdown

Code Coverage Overview

Languages: PHP

PHP / code-coverage/phpunit

The overall line coverage in commit 72f5487 in the parse-percent-occupi... branch is 90%. The line coverage in commit 2949ba3 in the master branch is 89%.

Show a line coverage summary of the most impacted files.
File master 2949ba3 parse-percent-occupi... 72f5487 +/-
InterOp/RunResult.php 100% 100% 0%
PHPStan/Rules/M...ypehintRule.php 0% 88% +88%
PHPStan/Rules/M...ypehintRule.php 0% 100% +100%
PHPStan/Rules/C...ypehintRule.php 0% 100% +100%

@dhaupt88 dhaupt88 changed the title feat: parse % Occupied from InterOp summary feat!: parse % Occupied from InterOp summary Sep 14, 2026
@dhaupt88
dhaupt88 marked this pull request as ready for review September 14, 2026 09:05
@dhaupt88
dhaupt88 merged commit e256f1d into master Sep 14, 2026
55 of 56 checks passed
@dhaupt88
dhaupt88 deleted the parse-percent-occupied branch September 14, 2026 09:05
github-actions Bot pushed a commit that referenced this pull request Sep 14, 2026
## [6.15.0](v6.14.0...v6.15.0) (2026-09-14)

### Features

* **interop:** expose percent occupied of patterned flowcells ([#95](#95)) ([e256f1d](e256f1d))
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant