Skip to content

BERT - #30

Draft
mrityunjay-tripathi wants to merge 11 commits into
mlpack:masterfrom
mrityunjay-tripathi:bert
Draft

BERT#30
mrityunjay-tripathi wants to merge 11 commits into
mlpack:masterfrom
mrityunjay-tripathi:bert

Conversation

@mrityunjay-tripathi

@mrityunjay-tripathimrityunjay-tripathi commented Aug 18, 2020

Copy link
Copy Markdown
Member

No description provided.

@mrityunjay-tripathi
mrityunjay-tripathi marked this pull request as draft August 21, 2020 12:14
lozhnikov
lozhnikov reviewed Aug 24, 2020
View reviewed changes

@lozhnikovlozhnikov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

Comment threadmodels/bert/bert_tokenizer.hpp Outdated
Comment threadutils/utils.hpp Outdated
Comment threadutils/utils.hpp Outdated
Comment threadutils/utils.hpp Outdated
Comment threadutils/utils.hpp Outdated
@mlpack-bot

mlpack-botBot commented Oct 30, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@ayushsingh11

ayushsingh11 commented Mar 7, 2021•
edited
Loading

Copy link
Copy Markdown

My bad, I didn't know that there was an attempt to add BERT Tokenizer earlier as well.
Hence, I have added a PR - mlpack/mlpack#2822 .
But, it is for the 'mlpack' repos, not 'models'.

@ayushsingh11ayushsingh11 mentioned this pull request Mar 9, 2021
Closed
@rcurtinrcurtin mentioned this pull request Nov 9, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lozhnikovlozhnikovlozhnikov left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

s: keep opens: needs reviewt: added feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrityunjay-tripathi@ayushsingh11@lozhnikov@kartikdutt18