Skip to content

fix: using correct focal length variable for last example - #2

Merged
mnslarcher merged 1 commit into
mnslarcher:mainfrom
alexflorensa:main
Jun 29, 2022
Merged

fix: using correct focal length variable for last example#2
mnslarcher merged 1 commit into
mnslarcher:mainfrom
alexflorensa:main

Conversation

@alexflorensa

Copy link
Copy Markdown
Contributor

In the parameter declaration of the last example, FOCAL_LENGTH is used, but in the following part of the code, F is used as focal length:

Z = PrincipalAxis(
    camera_center=C,
    camera_dz=camera_frame.dz,
    f=F,
)

This PR fixes the above code to make use of the FOCAL_LENGTH variable, instead of F, that refers to a previous example.

@mnslarcher

Copy link
Copy Markdown
Owner

Thanks @alexflorensa !

@mnslarcher
mnslarcher merged commit 87b4f8b into mnslarcher:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants