Uh oh!
There was an error while loading. Please reload this page.
Feature: support destination persistent connections attribute - #13
Feature: support destination persistent connections attribute#13kwanhur wants to merge 2 commits into
Conversation
Signed-off-by: kwanhur <huang_hua2012@163.com>
kwanhur
commented
Mar 18, 2020
check failed details do not relate with the feature codes |
andrewsykim
left a comment
There was a problem hiding this comment.
@kwanhur looks like github thinks the email you are using is invalid, would it be possible to use a valid email address?
| case ipvsDestAttrInactiveConnections: | ||
| d.InactiveConnections = int(native.Uint16(attr.Value)) | ||
| case ipvsDestAttrPersistentConnections: | ||
| d.PersistentConnections = int(native.Uint16(attr.Value)) |
There was a problem hiding this comment.
Looking at the kernel implementation this should be uint32?
There was a problem hiding this comment.
Yeap, the connection attributes ActiveConnectionsInactiveConnectionsPersistentConnections also should be uint32. Unified could be better.
kwanhur
commented
May 1, 2020
it has been valid :-) |
andrewsykim
commented
May 1, 2020
Seeing this on github actions: Maybe it's been fixed now, can you rebase and fix conflicts? |
Signed-off-by: kwanhur <huang_hua2012@163.com>
kwanhur
commented
Jun 25, 2020
conflicts have been fixed ：） |
kwanhur
commented
Aug 7, 2020
Ping @andrewsykim how about this PR? |
Add
PersistentConnectionsattribute inDestinationstruct