Uh oh!
There was an error while loading. Please reload this page.
Fix IPMask marshalling - #1968
Merged
Merged
Conversation
Fix marshalling and add test Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
codecov-io
commented
Oct 4, 2017
Codecov Report
@@ Coverage Diff @@## master #1968 +/- ##
========================================
Coverage ? 38.5% ========================================
Files ? 137 Lines ? 27351 Branches ? 0 ========================================
Hits ? 10531 Misses ? 15523 Partials ? 1297
Continue to review full report at Codecov.
|
mavenugo
commented
Oct 4, 2017
Contributor
Thanks for taking care of it @fcrisciani . LGTM |
mavenugo
commented
Oct 4, 2017
Contributor
I will spend some time on this offline to see why the unmarshalling didnt work with IPMask string formating, |
mavenugo
approved these changes
Oct 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix marshalling and add test
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com