Uh oh!
There was an error while loading. Please reload this page.
[WIP] DO NOT MERGE YET Revert "[Backport 17.06] Overlay fix for transient IP reuse" - #1970
[WIP] DO NOT MERGE YET Revert "[Backport 17.06] Overlay fix for transient IP reuse"#1970andrewhsu wants to merge 1 commit into
Conversation
GordonTheTurtle
commented
Oct 4, 2017
Please sign your commits following these rules: $ git clone -b "revert-1965-backport-17.06" git@github.com:andrewhsu/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
andrewhsu
commented
Oct 4, 2017
cc @mavenugo |
mavenugo
commented
Oct 4, 2017
@andrewhsu reverting this will affect #1969. Are you sure about it ? cc @fcrisciani |
This fix is taking care of the failure that I was seeing yesterday. #1969 |
mavenugo
commented
Oct 5, 2017
@fcrisciani since #1969 is opened against the bump_17.06 branch and it is dependent on #1965... reverting #1965 will make #1969 useless. So am not sure what is the purpose of this PR, when #1969 was opened to address the issue ? |
andrewhsu
commented
Oct 5, 2017
this is not needed anymore because we got #1969 |
Reverts #1965
From discussion with @fcrisciani, needs more work. Better to revert for now so we can vndr the
bump_17.06branch with changes from @abhi.