Skip to content

Fix watchMiss thread context - #2051

Merged
fcrisciani merged 1 commit into
moby:masterfrom
fcrisciani:fix-watchMiss-ns
Jan 11, 2018
Merged

Fix watchMiss thread context#2051
fcrisciani merged 1 commit into
moby:masterfrom
fcrisciani:fix-watchMiss-ns

Conversation

@fcrisciani

@fcriscianifcrisciani commented Jan 10, 2018

Copy link
Copy Markdown

The netlink deserialize is fetching information for the link.
This require the go routine to be in the correct namespace to
succeed

Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com

The netlink deserialize is fetching information from the link.
This require the go routine to be in the correct namespace to
succeed
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>

@abhiabhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcrisciani

Copy link
Copy Markdown
Author

Fixes #2045

@codecov-io

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@315a076). Click here to learn what that means.
The diff coverage is 41.66%.

Impacted file tree graph

@@ Coverage Diff @@## master #2051 +/- ##
=========================================
Coverage ? 40.45% =========================================
Files ? 138 Lines ? 22160 Branches ? 0 =========================================
Hits ? 8965 Misses ? 11877 Partials ? 1318
Impacted FilesCoverage Δ
drivers/overlay/ov_network.go2.8% <41.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315a076...1717eee. Read the comment docs.

@ddebroyddebroy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@fcrisciani@codecov-io@abhi@ddebroy