Skip to content

[WIP] migration to circleci 2.0 - #2107

Closed
fcrisciani wants to merge 2 commits into
moby:masterfrom
fcrisciani:circleci2.0
Closed

[WIP] migration to circleci 2.0#2107
fcrisciani wants to merge 2 commits into
moby:masterfrom
fcrisciani:circleci2.0

Conversation

@fcrisciani

Copy link
Copy Markdown

Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com

@fcrisciani
fcriscianiforce-pushed the circleci2.0 branch 22 times, most recently from da3f3b7 to a0ffe28CompareMarch 12, 2018 17:19
@fcrisciani
fcriscianiforce-pushed the circleci2.0 branch 2 times, most recently from e8bbc7c to 3c80f06CompareApril 11, 2018 00:06
This commit will allow us to use newer version of CircleCI.
Signed-off-by: selansen <elango.siva@docker.com>
@fcrisciani
fcriscianiforce-pushed the circleci2.0 branch 5 times, most recently from 0f56c3f to d0f3fd8CompareJune 7, 2018 22:36
@fcrisciani
fcriscianiforce-pushed the circleci2.0 branch 22 times, most recently from 67d64b5 to 2d9637aCompareJune 8, 2018 03:55
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Comment threadMakefile
pushd . &> /dev/null ; \
cd $$dir ; \
go test ${INSIDECONTAINER} -test.parallel 5 -test.v -covermode=count -coverprofile=./profile.tmp ; \
go test ${INSIDECONTAINER} -test.v test.parallel 5 -covermode=count -coverprofile=./profile.tmp ; \

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing the - to parallel

Comment threadMakefile

integration-tests: ./bin/dnet
@./test/integration/dnet/run-integration-tests.sh
integration-tests:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going away

Comment threadDockerfile.build
github.com/gordonklaus/ineffassign \
github.com/client9/misspell/cmd/misspell \
honnef.co/go/tools/cmd/gosimple

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@fcrisciani

Copy link
Copy Markdown
Author

Closing in favor of: #2168

@fcrisciani
fcrisciani deleted the circleci2.0 branch June 15, 2018 15:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fcrisciani@selansen