Uh oh!
There was an error while loading. Please reload this page.
Update stretchr/testify to v1.2.2 - #2213
Merged
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jun 28, 2018
MemberAuthor
selansen
commented
Jun 29, 2018
Contributor
LGTM |
fcrisciani
commented
Jul 3, 2018
@vdemeester can you point to the script? |
vdemeester
commented
Jul 4, 2018
Member
(and yes I can run it on libnetwork and see how it goes ;) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainly because stretchr/testify#190, but saw this version was quite old, so updated to the current release.
we should probably switch to gotest.tools, which is now used in other repositories; I think @vdemeester may be able to help with that switch (think there's a migration script)