Skip to content

[18.03 backport] Cleanup the cluster provider when the agent is closed - #2353

Merged
mavenugo merged 1 commit into
moby:bump_18.03from
thaJeztah:18.03_backport_fix_agent_init_problem
Apr 15, 2019
Merged

[18.03 backport] Cleanup the cluster provider when the agent is closed#2353
mavenugo merged 1 commit into
moby:bump_18.03from
thaJeztah:18.03_backport_fix_agent_init_problem

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Apr 1, 2019

Copy link
Copy Markdown
Member

backport of #2307 for the 18.03 branch

@kylewuolle@thaJeztah
Cleanup the cluster provider when the agent is closed
42972ca
Signed-off-by: Kyle Wuolle <kyle.wuolle@gmail.com>
(cherry picked from commit c7125bd)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

thaJeztah commented Apr 1, 2019

Copy link
Copy Markdown
MemberAuthor

ping @mavenugo@euanh PTAL

@selansen

selansen commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

looks like TestNetworkDBIslands failing consistently ( Same failure on other backport too )

@thaJeztah

thaJeztah commented Apr 1, 2019

Copy link
Copy Markdown
MemberAuthor
--- FAIL: TestNetworkDBIslands (75.83s)
Location:	networkdb_test.go:838
Error: "map[4ac5b1d46794:4ac5b1d46794 79fd1a707bd6:79fd1a707bd6]" should have 3 item(s), but has 2
Location:	networkdb_test.go:839
Error: "map[2624cc77ef1d:2624cc77ef1d]" should have 0 item(s), but has 1
FAIL

Looks like it may be flaky #2240 (comment)

@thaJeztah

thaJeztah commented Apr 1, 2019

Copy link
Copy Markdown
MemberAuthor

Don't have permissions to trigger CI in this repo 😕

@selansen

selansen commented Apr 1, 2019

Copy link
Copy Markdown
Contributor

Like I mentioned , I did see same error failure in my PRs few times in the past.
I think we can merge it adding a note on this test case.

selansen
selansen approved these changes Apr 1, 2019
View reviewed changes

@selansenselansen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .

@kylewuollekylewuolle mentioned this pull request Apr 12, 2019
Merged
@kylewuolle

kylewuolle commented Apr 12, 2019

Copy link
Copy Markdown
Contributor

ping @mavenugo@euanh !

@mavenugo
mavenugo merged commit 6eca140 into moby:bump_18.03Apr 15, 2019
@thaJeztah
thaJeztah deleted the 18.03_backport_fix_agent_init_problem branch April 18, 2019 08:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@selansenselansenselansen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@selansen@kylewuolle@mavenugo