Rename a existing container - #8570

Merged
jessfraz merged 1 commit into
moby:masterfrom
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged

Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom
brahmaroutu:rename_container_3036

Conversation

@brahmaroutu

@brahmaroutubrahmaroutu commented Oct 14, 2014

Copy link
Copy Markdown
Contributor

Addresses #3036

Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com

@brahmaroutu
brahmaroutuforce-pushed the rename_container_3036 branch 4 times, most recently from cb27f73 to 73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit reviewed Oct 29, 2014
View reviewed changes
Comment threaddocs/man/docker-rename.1.md Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)

@brahmaroutubrahmaroutuOct 29, 2014

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.

@brahmaroutubrahmaroutuOct 29, 2014

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).

@SvenDowideit

SvenDowideit commented Oct 29, 2014

Copy link
Copy Markdown
Contributor

oh, yes, i would like this. Docs LGTM -

now for an implementation question.

what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))

@brahmaroutu
brahmaroutuforce-pushed the rename_container_3036 branch 2 times, most recently from 1f39e4c to 62892b9CompareOctober 29, 2014 03:09
@brahmaroutu

brahmaroutu commented Oct 29, 2014

Copy link
Copy Markdown
ContributorAuthor

About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.

@SvenDowideit

SvenDowideit commented Oct 30, 2014

Copy link
Copy Markdown
Contributor

nice - @jamtur01@fredlf

plus you need core review, @crosbymichael@tiborvass ?

@SvenDowideitSvenDowideit changed the title rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf reviewed Nov 3, 2014
View reviewed changes
Comment threaddocker/flags.go Outdated

@fredlffredlfNov 3, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.

@fredlf

fredlf commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.

Still needs core review. Ping @crosbymichael@tiborvass

Many thanks for the contribution.

@tiborvasstiborvass changed the title Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass

tiborvass commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

@brahmaroutu Thanks for your contribution.

I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).

Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.

@brahmaroutu

brahmaroutu commented Nov 3, 2014

Copy link
Copy Markdown
ContributorAuthor

@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.

@fredlf

fredlf commented Nov 3, 2014

Copy link
Copy Markdown
Contributor

No problem, and thanks!

@brahmaroutu
brahmaroutuforce-pushed the rename_container_3036 branch 3 times, most recently from 50c38fb to 7712f98CompareDecember 2, 2014 20:31
@shykes

shykes commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

Design review with @icecrime

I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).

@shykesshykes removed UX labels Dec 23, 2014
@shykes

shykes commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

#uxapproved

jessfraz
jessfraz reviewed Dec 23, 2014
View reviewed changes
Comment threadintegration-cli/docker_cli_links_test.go Outdated

@jessfrazjessfrazDec 23, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers

@LK4D4

LK4D4 commented Jan 9, 2015

Copy link
Copy Markdown
Contributor

ping @jfrazelle@icecrime@tiborvass

icecrime
icecrime reviewed Jan 9, 2015
View reviewed changes
Comment threaddaemon/rename.go

@icecrimeicecrimeJan 9, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):

$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.

@brahmaroutubrahmaroutuJan 9, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.

@icecrime

icecrime commented Jan 9, 2015

Copy link
Copy Markdown
Contributor

Not LGTM: there is a blocking issue (see my comment).

@brahmaroutu

brahmaroutu commented Jan 9, 2015

Copy link
Copy Markdown
ContributorAuthor

Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?

@icecrime

icecrime commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!

@vieux

vieux commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

I would use GET parameter:

"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu

brahmaroutu commented Jan 13, 2015

Copy link
Copy Markdown
ContributorAuthor

@vieux Can you also let me know if I should change it to PUT call?

@vieux

vieux commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

Sorry I meant a POST /containers/{name:.*}/rename?name={newname}

We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST

Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu

brahmaroutu commented Jan 13, 2015

Copy link
Copy Markdown
ContributorAuthor

@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments

@LK4D4

LK4D4 commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

LGTM

@thaJeztah

thaJeztah commented Jan 13, 2015

Copy link
Copy Markdown
Member

fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.

(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)

@jessfraz

jessfraz commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

LGTM

jessfraz pushed a commit that referenced this pull request Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz merged commit b9e42d6 into moby:masterJan 13, 2015
@cpuguy83cpuguy83 mentioned this pull request Jan 13, 2015
Closed
@vieux

vieux commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

No API bump ?
No New section in docs/sources/reference/api/docker_remote_api.md ?

@jessfraz

jessfraz commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

@vieux making patch now

@vieux

vieux commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

@jfrazelle thank you.

@vieux

vieux commented Jan 13, 2015

Copy link
Copy Markdown
Contributor

It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.

@brahmaroutu

brahmaroutu commented Jan 13, 2015

Copy link
Copy Markdown
ContributorAuthor

@jfrazelle thanks, let me know if I can help.

thaJeztah added a commit to thaJeztah/docker that referenced this pull request Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah mentioned this pull request Jan 13, 2015
Merged
@brahmaroutu

brahmaroutu commented Jan 14, 2015

Copy link
Copy Markdown
ContributorAuthor

@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.

@brahmaroutu
brahmaroutu deleted the rename_container_3036 branch January 15, 2015 18:03
@aanandaanand mentioned this pull request Jan 23, 2015
Closed
@SvenDowideitSvenDowideit mentioned this pull request Jan 27, 2015
Merged
@VynceMontgomeryVynceMontgomery mentioned this pull request Jun 3, 2015
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rename a existing container - #8570
Merged
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Jan 13, 2015
Merged
Rename a existing container#8570
jessfraz merged 1 commit into
moby:masterfrom 
brahmaroutu:rename_container_3036
Conversation
@brahmaroutu
@brahmaroutubrahmaroutu
commented
Oct 14, 2014

Copy link


Copy Markdown

Contributor
Addresses #3036
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
4 times, most recently
from
cb27f73 to
73a69acCompareOctober 16, 2014 18:24
SvenDowideit
SvenDowideit
reviewed
Oct 29, 2014
 View reviewed changes

Comment threaddocs/man/docker-rename.1.md
Outdated

@SvenDowideitSvenDowideitOct 29, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lies! i never wrote this ;)
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops let me see, It may be just a cut and paste issue.
@brahmaroutubrahmaroutuOct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It is a cut and paste errors(now removed).
@SvenDowideit
SvenDowideit
commented
Oct 29, 2014

Copy link


Copy Markdown

Contributor
oh, yes, i would like this. Docs LGTM -
now for an implementation question.
what happens when you rename a container that has been linked to? does everything still hand together? (I presume so, but :))
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
2 times, most recently
from
1f39e4c to
62892b9CompareOctober 29, 2014 03:09
@brahmaroutu
brahmaroutu
commented
Oct 29, 2014

Copy link


Copy Markdown

ContributorAuthor
About the links, they work after rename, I tested them manually and also have integration tests that I can add, please let me know. I see the link is actually added to hosts file using IP address and container name is not used.
@SvenDowideit
SvenDowideit
commented
Oct 30, 2014

Copy link


Copy Markdown

Contributor
nice - @jamtur01@fredlf
plus you need core review, @crosbymichael@tiborvass ?
@SvenDowideitSvenDowideit
changed the title
rename a existing containerProposal: Rename a existing containerOct 30, 2014
fredlf
fredlf
reviewed
Nov 3, 2014
 View reviewed changes

Comment threaddocker/flags.go
Outdated

@fredlffredlfNov 3, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "an existing", here and below.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
Docs LGTM from me once the grammar mistake is fixed. Ping @jamtur01 @ostezer.
Still needs core review. Ping @crosbymichael@tiborvass
Many thanks for the contribution.
@tiborvasstiborvass
changed the title
Proposal: Rename a existing containerRename a existing containerNov 3, 2014
@tiborvass
tiborvass
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
@brahmaroutu Thanks for your contribution.
I'd like to note though that this is not a proposal (hence my editing of the title). A proposal is either in a form of an issue explaining what are the changes needed and why, OR a PR to the documentation explaining what would change if it were implemented (see #8859 as an example).
Design needs to be reviewed with @shykes. Sorry if it's taking longer than expected! I'll make sure we review this in the next design review session.
@brahmaroutu
brahmaroutu
commented
Nov 3, 2014

Copy link


Copy Markdown

ContributorAuthor
@fredlf Sorry, I made that minor change to docs.
@tiborvass Thanks for reviewing, I understand such changes require more diligent review considerations.
@fredlf
fredlf
commented
Nov 3, 2014

Copy link


Copy Markdown

Contributor
No problem, and thanks!
@brahmaroutu
brahmaroutuforce-pushed
the
rename_container_3036
branch
3 times, most recently
from
50c38fb to
7712f98CompareDecember 2, 2014 20:31
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
Design review with @icecrime
I approve docker rename OLD NEW. I haven't looked at the implementation. In particular please make sure edge cases are properly handled in the underlying storage (graphdb etc).
@shykesshykes
removed

UX

labels
Dec 23, 2014
@shykes
shykes
commented
Dec 23, 2014

Copy link


Copy Markdown

Contributor
#uxapproved
jessfraz
jessfraz
reviewed
Dec 23, 2014
 View reviewed changes

Comment threadintegration-cli/docker_cli_links_test.go
Outdated

@jessfrazjessfrazDec 23, 2014

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are needed if you deleteAllContainers
@LK4D4
LK4D4
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
ping @jfrazelle@icecrime@tiborvass
icecrime
icecrime
reviewed
Jan 9, 2015
 View reviewed changes

Comment threaddaemon/rename.go
@icecrimeicecrimeJan 9, 2015

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a major issue here, as error is returned without releasing the lock (same for the code path right above):
$ docker run --name test busybox true
$ docker rename test " "
Error response from daemon: Error when allocating new name: Invalid container name ( ), only [a-zA-Z0-9][a-zA-Z0-9_.-] are allowed
FATA[0000] Error: failed to rename container named test
$ docker ps -a # Hangs (probably daemon in deadlock)

I think we should use defer container.Unlock() to play safe.
@brahmaroutubrahmaroutuJan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added defer on Unlock. thanks for pointing it out.
@icecrime
icecrime
commented
Jan 9, 2015

Copy link


Copy Markdown

Contributor
Not LGTM: there is a blocking issue (see my comment).
@brahmaroutu
brahmaroutu
commented
Jan 9, 2015

Copy link


Copy Markdown

ContributorAuthor
Please let me know if I change it to the first ever PUT on Docker server, makes sense, instead of POST?
@icecrime
icecrime
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Can we get an API maintainer input on the method to use so we can move on with this cool PR? Ping @vieux@jfrazelle!
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
I would use GET parameter:
"/containers/{name:.*}/rename?name={newname}"

@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux Can you also let me know if I should change it to PUT call?
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
Sorry I meant a POST /containers/{name:.*}/rename?name={newname}
We don't have any PUT on the API, we use only POST, GET or DELETE to I would stay on the POST
Srini Brahmaroutu@brahmaroutu
rename a existing container
21a809d
Closesmoby#3036
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@vieux@cpuguy83@LK4D4 Please review, code is updated as per your comments
@LK4D4
LK4D4
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
@thaJeztah
thaJeztah
commented
Jan 13, 2015

Copy link


Copy Markdown

Member
fwiw; since I'm the one coming up with PUT originally; I'm fine with POST for consistency with the rest of the API.
(If the need ever rises to be more "strict", I think that would require a complete review of the whole API)
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
LGTM
jessfraz pushed a commit
that referenced
this pull request
Jan 13, 2015
Jessie Frazelle
Merge pull request#8570from brahmaroutu/rename_container_3036
b9e42d6
Rename a existing container
@jessfraz
jessfraz
merged commit b9e42d6
into
moby:masterJan 13, 2015
@cpuguy83cpuguy83
mentioned this pull request
Jan 13, 2015

Closed

@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
No API bump ?

No New section in docs/sources/reference/api/docker_remote_api.md ?
@jessfraz
jessfraz
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@vieux making patch now
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
@jfrazelle thank you.
@vieux
vieux
commented
Jan 13, 2015

Copy link


Copy Markdown

Contributor
It's easier for us when there is doc, every week we can look and see if we need to add the new endpoints in swarm.
@brahmaroutu
brahmaroutu
commented
Jan 13, 2015

Copy link


Copy Markdown

ContributorAuthor
@jfrazelle thanks, let me know if I can help.
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Jan 13, 2015
@thaJeztah
Mention "or rename" again in error-message.
78820a6
The "or rename" part was removed from the error-message,
because renaming wasn't possible at the time.
Now that moby#8570 is merged,
renaming existing containers is possible.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah
mentioned this pull request
Jan 13, 2015
 Merged

@brahmaroutu
brahmaroutu
commented
Jan 14, 2015

Copy link


Copy Markdown

ContributorAuthor
@borromeotlhs there are not many tests testing 409 and I did not add one. I can quickly add a test if you want but I need a issue to do so.
@brahmaroutu
brahmaroutu
deleted the

rename_container_3036

branch
January 15, 2015 18:03
@aanandaanand
mentioned this pull request
Jan 23, 2015

Closed

@SvenDowideitSvenDowideit
mentioned this pull request
Jan 27, 2015
 Merged

@VynceMontgomeryVynceMontgomery
mentioned this pull request
Jun 3, 2015

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

15 participants

@brahmaroutu@SvenDowideit@fredlf@tiborvass@shykes@thaJeztah@LK4D4@icecrime@vieux@jessfraz@crquan@cpuguy83@borromeotlhs@jamtur01@crosbymichael