Uh oh!
There was an error while loading. Please reload this page.
Add Go 1.23, drop 1.21, bump golangci-lint - #147
Merged
Conversation
kolyshkin
commented
Aug 13, 2024
CollaboratorAuthor
Apparently it works! |
kolyshkinforce-pushed
the
go123
branch
2 times, most recently
from
August 13, 2024 21:59
bceec56 to
cd7f11fComparekolyshkin
commented
Aug 14, 2024
CollaboratorAuthor
This is failing now because linter finds some issues with the old unescape implementation which is being replaced in #144. Once that one is merged, this one will need a rebase. |
thaJeztah
commented
Sep 9, 2024
Member
This one can be rebased |
Also, bump golangci-lint to v1.60.1 (which adds Go 1.23 support). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
commented
Sep 13, 2024
CollaboratorAuthor
Rebased; no longer a draft. |
kolyshkin
marked this pull request as ready for review
September 13, 2024 20:37
kolyshkin
commented
Sep 16, 2024
CollaboratorAuthor
@thaJeztah PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Go 1.23, drop 1.21.
Also, bump golangci-lint to v1.60.1 (which adds Go 1.23 support).
A draft pending #144 merge.