Uh oh!
There was an error while loading. Please reload this page.
symlink: drop go 1.13, and use testing.Cleanup() - #55
Conversation
thaJeztah
commented
Nov 5, 2020
relates to #54 (comment) /cc @kolyshkin |
| func TestFollowSymlinkAbsolute(t *testing.T) { | ||
| tmpdir, cleanup := mkTempDir(t) | ||
| defer cleanup() | ||
| tmpdir := mkTempDir(t) |
There was a problem hiding this comment.
Why don't we use t.TempDir() here? https://golang.org/pkg/testing/#T.TempDir
Ahh, this is because they are only supported since 1.15, so we need to wait at least until 1.14 is no longer supported.
Makes sense to add a TODO maybe?
There was a problem hiding this comment.
Ah, yes, can add a TODO
(didn't know about the t.TempDir() until you mentioned it recently. I should catch up more on new features 😂)
There was a problem hiding this comment.
Can't use this shiny new t.TempDir() anyway until 1.14 goes out of fashion...
Cleanup was added in Go 1.14, so we need to drop go 1.13 for this. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
b26c51b to
f59b804Compare
kolyshkin
left a comment
There was a problem hiding this comment.
LGTM except for a missing TODO
kolyshkin
commented
Feb 16, 2021
@cpuguy83 PTAL |
1 similar comment
kolyshkin
commented
Feb 24, 2021
@cpuguy83 PTAL |
Cleanup was added in Go 1.14, so we need to drop go 1.13 for this.