Uh oh!
There was an error while loading. Please reload this page.
switch to use blackbox testing, move tests to separate module - #35
switch to use blackbox testing, move tests to separate module#35thaJeztah wants to merge 1 commit into
Conversation
d2ad08c to
d2f5e41Compared2f5e41 to
6523db6Compare6523db6 to
a5b1cb2ComparethaJeztah
commented
Dec 5, 2022
Okay, moved this out of draft for consideration. |
| newSize := Winsize{Width: 200, Height: 200, x: winSize.x, y: winSize.y} | ||
| newSize := Winsize{Width: 200, Height: 200} |
There was a problem hiding this comment.
Ah, I think this was the bit I was still looking at. It's somewhat unclear why x and y aren't exported; effectively WinSize in this module is identical to golang.org/x/sys/unix.Winsize`;
Type in this module:
// Winsize represents the size of the terminal window.typeWinsizestruct {
Heightuint16Widthuint16xuint16yuint16
}And in golang.org/x/sys:
typeWinsizestruct {
Rowuint16Coluint16Xpixeluint16Ypixeluint16
}In this module, we're converting the types between, so perhaps instead we should make it an alias (and deprecate the local type). Let me look at that.
There was a problem hiding this comment.
Oh! I recall now; for Windows, it's a different type, so we can make it an alias (but only on !windows)
There was a problem hiding this comment.
Hm.. nevermind; field names are different 🤦
a6a5c39 to
3e71216Comparec20e276 to
ff86c79CompareThis allows us to remove the test-dependencies from the module itself Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ff86c79 to
6a9517eCompare
This allows us to remove the test-dependencies from the module itself.