Uh oh!
There was an error while loading. Please reload this page.
feat: add support for webassembly - #49
Open
remyleone wants to merge 1 commit into
Open
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
remyleoneforce-pushed
the
webassembly
branch
3 times, most recently
from
August 21, 2025 12:30
f840c9c to
d41322bComparejkroepke
commented
Jun 20, 2026
I'm looking forward to this. |
Signed-off-by: Rémy Léone <rleone@scaleway.com>
There was a problem hiding this comment.
Pull request overview
This PR adds a GOOS=js (WebAssembly via js/wasm) implementation of the term package and adjusts existing Unix build constraints so that Unix-specific code is excluded when building for js.
Changes:
- Exclude
jsfrom Unix/termios implementations via updated build tags. - Add a new
term_webassembly.gofile implementing the platform-specifictermfunctions forGOOS=js. - Route
term_unix.goand related termios files away fromjsbuilds to avoid Unix syscalls on WebAssembly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| termios_unix.go | Updates build tags to exclude js builds from Unix termios implementation. |
| termios_nonbsd.go | Updates build tags to exclude js builds from non-BSD Unix termios constants. |
| term_webassembly.go | Adds GOOS=js implementation of terminal APIs for WebAssembly builds. |
| term_unix.go | Updates build tags to exclude js builds from Unix terminal implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+31
| func saveState(fd uintptr) (*State, error) { | ||
| return &State{}, nil | ||
| } | ||
Comment on lines
+17
to
+22
| func getWinsize(fd uintptr) (*Winsize, error) { | ||
| window := js.Global().Get("window") | ||
| width := uint16(window.Get("innerWidth").Int()) | ||
| height := uint16(window.Get("innerHeight").Int()) | ||
| return &Winsize{Width: width, Height: height}, nil | ||
| } |
Comment on lines
+24
to
+26
| func isTerminal(fd uintptr) bool { | ||
| return true | ||
| } |
Comment on lines
+50
to
+56
| func setWinsize(fd uintptr, ws *Winsize) error { | ||
| window := js.Global().Get("window") | ||
| window.Set("innerWidth", ws.Width) | ||
| window.Set("innerHeight", ws.Height) | ||
| return nil | ||
| } |
Comment on lines
+1
to
+2
| //go:build !js && !windows | ||
| // +build !js,!windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for webassembly in term. I need this patch for compiling kubectl to webassembly kubernetes/kubernetes#133638