Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses most of #604.
Adds multiple sets of pipe connector graphics to boblibrary, so that they can be uses non-redundantly by the multiple mods that need them.
Old connectors are the ones previously used by Assembling Machine 2, and are applied to the Steam Assembling Machine. The universal connectors are based on the old Assembling Machine 3 connectors, but have been modified to fill in some of the holes they had. The thin connectors were modified in the same way, and are based on the 2.1 Assembler 3 connectors. The "short" connectors come from the same source, and are used specifically for Electronics Assemblers, which none of the other connectors fit on in a way that looks remotely reasonable. Even then, I needed to increase the size of the machines to scale = 0.38 (a scale already used for AAI Loaders) in order to make things fit.
Also adds new graphics for Assembling Machines. Since color masks are unfeasible, I made recolors of the full animation set. Not as much work as it sounds. However, hue-shifting doesn't work on the new Assembling Machine 3 graphics, so our Assembling Machines 2-5 are now all using the Assembling Machine 2 graphics.
Made a slight adjustment to the graphics of the Stone Chemical Furnace to hide a visible incomplete pipe that shows up when you build it in a flipped orientation. Stone Chemical Furnace and the two Small Storage Tanks are the only entities that still use the base game's pipe connectors - they seem to look perfectly fine as they are.