Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As brought up in #526, this PR adds new functions that add, remove, or set any technology modifier, as well as adding functionality to add_recipe_unlock to control where the new addition is added - at a specific index, or before or after a specific existing subtable. add_tech_modifier also has this functionality.
These can be used to organize the way technologies are presented to be more clean and organized. I went through a few example files and applied the new functionality to them.
This also gives us the tools to easily maintain consistency even when Space Age randomly decides to change the value of some of these bonuses. For example, the turret attack damage bonus is only 0.2 in Space Age on Physical Attack Damage levels 6 and 7, instead of the vanilla values of 0.4 and 0.7.
In addition, I finally created the function for changing a recycling recipe to a self-recycling one. I also fixed an oversight in the existing recycling update functions so that the number of outputs in the base recipe will be taken into account when determining how long the item should take to recycle, instead of that only counting toward the quantity/probability of outputs.