Skip to content

RFC: Loop Contracts - #3167

Merged
qinheping merged 9 commits into
model-checking:mainfrom
qinheping:rfc-loop-contracts
Sep 4, 2024
Merged

RFC: Loop Contracts#3167
qinheping merged 9 commits into
model-checking:mainfrom
qinheping:rfc-loop-contracts

Conversation

@qinheping

@qinhepingqinheping commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

RFC for loop contracts in Kani.

Rendered version available here.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@qinheping
qinheping requested a review from a team as a code ownerApril 30, 2024 06:14
@qinhepingqinheping mentioned this pull request May 1, 2024
Closed
@feliperodrifeliperodri added the T-RFC Label RFC PRs and Issues label Jun 11, 2024
@tautschnigtautschnig added the Z-Contracts Issue related to code contracts label Aug 1, 2024
celinval
celinval reviewed Aug 2, 2024
View reviewed changes
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
feliperodri
feliperodri requested changes Aug 6, 2024
View reviewed changes
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
celinval
celinval reviewed Aug 19, 2024
View reviewed changes
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md
@qinheping

qinheping commented Aug 23, 2024

Copy link
Copy Markdown
ContributorAuthor

@celinval
I remove implementation detail as it was too much for RFC; and add more open questions.

celinval
celinval reviewed Aug 29, 2024
View reviewed changes

@celinvalcelinval left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qinheping! It's looking pretty good.

Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md Outdated
feliperodri
feliperodri approved these changes Aug 30, 2024
View reviewed changes

@feliperodrifeliperodri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing all the comments. LGTM!

celinval
celinval reviewed Aug 30, 2024
View reviewed changes

@celinvalcelinval left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one last question about feature opt-in / opt-out. Like contracts, I am not convinced that a user always wants the loop to be abstracted.

Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md
qinheping
qinheping commented Sep 1, 2024
View reviewed changes

@qinhepingqinheping left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@celinval Thank you!

Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md
Comment threadrfc/src/rfcs/0012-loop-contracts.md
celinval
celinval approved these changes Sep 3, 2024
View reviewed changes

@celinvalcelinval left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qinheping

@qinheping
qinheping added this pull request to the merge queueSep 4, 2024
Merged via the queue into model-checking:main with commit 701f6fbSep 4, 2024
@qinheping
qinheping deleted the rfc-loop-contracts branch September 4, 2024 22:45
@celinvalcelinval mentioned this pull request Oct 8, 2024
Merged
This was referenced Oct 9, 2024
Open
Open
This was referenced Nov 8, 2024
Closed
Closed
This was referenced Feb 3, 2025
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feliperodrifeliperodrifeliperodri approved these changes
@celinvalcelinvalcelinval approved these changes

Assignees

@qinhepingqinheping

Labels

T-RFCLabel RFC PRs and IssuesZ-ContractsIssue related to code contracts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qinheping@feliperodri@celinval@tautschnig