Skip to content

Add missing functionalities to kani_core - #3384

Merged
celinval merged 3 commits into
model-checking:mainfrom
celinval:issue-3257-missing
Jul 25, 2024
Merged

Add missing functionalities to kani_core#3384
celinval merged 3 commits into
model-checking:mainfrom
celinval:issue-3257-missing

Conversation

@celinval

Copy link
Copy Markdown
Contributor

Note that for adding any_array I had to cleanup the unnecessary usage of constant parameters from kani::any_raw.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

 - Add Arbitrary for array
- Add Arbitrary for tuples
- Add missing changes from modifies slices (model-checking#3295)
Note that for adding `any_array` I had to cleanup the unnecessary usage
of constant parameters from `kani::any_raw`.
@celinval
celinval requested a review from a team as a code ownerJuly 25, 2024 03:43
@github-actionsgithub-actionsBot added the Z-EndToEndBenchCI Tag a PR to run benchmark CI label Jul 25, 2024
Comment threadlibrary/kani/src/lib.rs

@jaisnanjaisnan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, this might make unification easier as well. Approving as the added function-contracts in the verify_core seem to check for regressions in newly added capabilities as well.

@celinval

Copy link
Copy Markdown
ContributorAuthor

Thanks for the cleanup, this might make unification easier as well. Approving as the added function-contracts in the verify_core seem to check for regressions in newly added capabilities as well.

BTW, I noticed that core crate contains a re-export of itself as core, so they can use core inside it. So we might be able to just use straight core:: for both versions (with and without core), so we may not need the $core argument to our macros.

@celinval
celinval enabled auto-merge (squash) July 25, 2024 17:23
@celinval
celinval merged commit b18698f into model-checking:mainJul 25, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-EndToEndBenchCITag a PR to run benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@celinval@jaisnan