Uh oh!
There was an error while loading. Please reload this page.
Update toolchain to 2024-08-05 - #3416
Merged
tautschnig merged 6 commits intoAug 5, 2024
Merged
Conversation
* Remove `gen_function_local_variable` and `initializer_fn_name`, the last uses of both of which were removed in model-checking#3305. * Remove `arg_count`, which was introduced in model-checking#3363, but not actually used. * Remove `insert_bb`, which was introduced in model-checking#3382, but not actually used. The toolchain upgrade to 2024-08-04 includes several bugfixes to dead-code analysis in rustc, explaining why we the recent PRs as listed above weren't flagged before for introducing dead code. Resolves: model-checking#3411
tautschnig
enabled auto-merge
August 5, 2024 10:01
tautschnig
disabled auto-merge
August 5, 2024 10:02
artemagvanian
commented
Aug 5, 2024
Contributor
Is it possible to temporarily mark |
This reverts commit 579f6e3.
tautschnig
commented
Aug 5, 2024
MemberAuthor
Done. |
zhassan-aws
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen_function_local_variableandinitializer_fn_name, the last uses of both of which were removed in Fix contract handling of promoted constants and constant static #3305.arg_count, which was introduced in Enable contracts in associated functions #3363, asallow(dead_code)as it will soon be used.insert_bb, which was introduced in Better explanations and extra functionality inMutableBody#3382, asallow(dead_code)as it will soon be used.The toolchain upgrade to 2024-08-04 includes several bugfixes to dead-code analysis in rustc, explaining why we the recent PRs as listed above weren't flagged before for introducing dead code.
Resolves: #3411
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.