Skip to content

List RFC revisions - #3490

Merged
carolynzech merged 6 commits into
model-checking:mainfrom
carolynzech:list-rfc-feedback
Sep 6, 2024
Merged

List RFC revisions#3490
carolynzech merged 6 commits into
model-checking:mainfrom
carolynzech:list-rfc-feedback

Conversation

@carolynzech

Copy link
Copy Markdown
Contributor

Addresses @jaisnan's feedback on list RFC--change human output to pretty and fix Kani version typo.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@carolynzech
carolynzech requested a review from a team as a code ownerSeptember 4, 2024 14:50

@jaisnanjaisnan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just a few small points left to address

Comment threadrfc/src/rfcs/0012-list.md Outdated
Comment threadrfc/src/rfcs/0012-list.md

@celinvalcelinval left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

Comment threadrfc/src/rfcs/0012-list.md Outdated
Comment threadrfc/src/rfcs/0012-list.md Outdated
Comment threadrfc/src/rfcs/0012-list.md Outdated
Comment threadrfc/src/rfcs/0012-list.md Outdated
Comment threadrfc/src/rfcs/0012-list.md Outdated
Comment threadrfc/src/rfcs/0012-list.md Outdated

@jaisnanjaisnan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the assumption that the schemas will be added to documentation sooner rather than later 👍

@carolynzech

carolynzech commented Sep 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Approving under the assumption that the schemas will be added to documentation sooner rather than later 👍

@jaisnan Yes, I'll make sure that the first release of this has schema documentation.

Comment threadrfc/src/rfcs/0013-list.md
@carolynzech
carolynzech added this pull request to the merge queueSep 6, 2024
Merged via the queue into model-checking:main with commit 2536f64Sep 6, 2024
@carolynzech
carolynzech deleted the list-rfc-feedback branch September 6, 2024 19:26
@celinvalcelinval mentioned this pull request Oct 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@carolynzech@celinval@jaisnan