Uh oh!
There was an error while loading. Please reload this page.
Update toolchain to 2024-09-20 - #3539
Conversation
Changes required due to: - rust-lang/rust@bdacdfe95f Minimize visibilities. Resolves: model-checking#3534
qinheping
left a comment
There was a problem hiding this comment.
I think it is OK to copy those functions in our code while waiting to see if they should be public in the upstream, and unblock the following toolchain updates.
Which way is better to remind us to review if these functions become pub in the future: mark them as FIXME, or create an issue to track them?
celinval
left a comment
There was a problem hiding this comment.
Can you try the following solution instead?
In the if block from the link function, I would replace the body by a call to link_binary as other backend implementations do, e.g. here.
You will also need to implement the ArchiveBuilderBuilder trait. I believe a dummy implementation as this should work.
Let me know if that makes sense.
This reverts commit 2755592.
celinval
commented
Sep 24, 2024
I guess it took me too long to post my comment. I created #3545 with the suggestion above. |
Replace the body by a call to link_binary as other backend implementations do, e.g. [rustc_codegen_gcc](https://github.com/rust-lang/rust/blob/648d024a7859e1ab7fdffe5e419b6e35ccb16a4a/compiler/rustc_codegen_gcc/src/lib.rs#L269-L271). Also remove the implementation of `metadata_loader` which has a [default body](https://github.com/rust-lang/rust/blob/11e760b7f4e4aaa11bf51a64d4bb7f1171f6e466/compiler/rustc_codegen_ssa/src/traits/backend.rs#L58-L60). By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Michael Tautschnig <tautschn@amazon.com>
Changes required due to:
Resolves: #3534
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.